#589 pwmStop wrong assert

[Lesto]

In "pwmStop" i see a check like:

chDbgAssert((pwmp->state == PWM_STOP) || (pwmp->state == PWM_READY),
"pwmStop(), #1", "invalid state");

but it seems like pwmp->state == PWM_READY is a valid state for stop.

[Giovanni Di Sirio]

Hi,

That assertions states STOP or READY is OK, everything else is not OK. The assertion is triggered if the expression evaluates to false.

Giovanni

[Lesto]

Yes my bad, sorry

On Sun, 3 May 2015 20:48 Giovanni Di Sirio gdisirio@users.sf.net wrote:

• status: open --> closed-invalid
• assigned_to: Giovanni Di Sirio
• Comment:

Hi,

That assertions states STOP or READY is OK, everything else is not OK. The
assertion is triggered if the expression evaluates to false.

Giovanni

• [bugs:#589] http://sourceforge.net/p/chibios/bugs/589 pwmStop wrong
  assert*

Status: closed-invalid

Affected Version: 2.6.6
Milestone: 2.6.9
Created: Fri May 01, 2015 08:33 PM UTC by Lesto
Last Updated: Fri May 01, 2015 08:33 PM UTC

Owner: Giovanni Di Sirio

In "pwmStop" i see a check like:

chDbgAssert((pwmp->state == PWM_STOP) || (pwmp->state == PWM_READY),
"pwmStop(), #1", "invalid state");

but it seems like pwmp->state == PWM_READY is a valid state for stop.

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/chibios/bugs/589/

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/