Menu ▾ ▴

#579 rules.mk should not explicitly depend on $(BUILDDIR)

3.0.0p4
closed
None
Low
3.0.0p3
True
2015-05-12
2015-04-14
marvin3k
No

rules.mk should not explicitly depend on $(BUILDDIR)

directly depending on actually created directories: $(OBJDIR) and $(LSTDIR) is better.

otherwise the Makefile is confused (and fails miserably) if someone else
creates by coincidence a directory named $(BUILDDIR) before.

See attached patch.

1 Attachments

Discussion

  • Giovanni Di Sirio

    • assigned_to: Giovanni Di Sirio
    • Affected Version: 3.0.0p2 --> 3.0.0p3
    • Milestone: 3.0.0p3 --> 3.0.0p4
    • Fixed in Repository: False --> True
     
  • Giovanni Di Sirio

    • status: open --> open-postponed
    • Fixed in Repository: True --> False
     
  • Giovanni Di Sirio

    The patch causes the rule to be executed twice.

     
  • marvin3k

    marvin3k - 2015-04-21

    Hm, I cannot confirm that. Here (GNU Make 4.0, ARMCMx, GCC) it looks more or less ok? Folders are created once, and if no VERBOSE mode the message is also printed once.

     
  • Giovanni Di Sirio

    Try parallel build, Eclipse does that when launching make.

     
  • marvin3k

    marvin3k - 2015-04-23

    Ah, I see.

    Edit: See the newly attached patch...

     

    Last edit: marvin3k 2015-04-23
  • Giovanni Di Sirio

    Committed.

     
  • Giovanni Di Sirio

    • Fixed in Repository: False --> True
     
  • Giovanni Di Sirio

    • status: open-postponed --> closed
     

Log in to post a comment.