Menu ▾ ▴

#481 Wrong check for STM32_I2S_USE_I2S3 in i2s_lld.h

closed-fixed
Giovanni Di Sirio
None
2014-05-09
2014-03-31
Morgoth
No

It seems there is a typo in recently added I2S header file. I mean i2s_lld.h file from os/hal/ports/STM32/LLD/SPIv1 directory:

========
#if STM32_I2S_USE_SPI2 && !defined(DOXYGEN)
extern I2SDriver I2SD2;
#endif

#if STM32_I2S_USE_I2S3 && !defined(DOXYGEN)
extern I2SDriver I2SD3;
#endif
========

The first check seems to be fine, but second one should be #if STM32_I2S_USE_SPI3 not #if STM32_I2S_USE_I2S3 I guess.

Discussion

  • Giovanni Di Sirio

    Giovanni Di Sirio - 2014-04-04
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,13 +1,13 @@
 It seems there is a typo in recently added I2S header file. I mean i2s_lld.h file from os/hal/ports/STM32/LLD/SPIv1 directory:

 ========
-#if STM32_I2S_USE_SPI2 && !defined(__DOXYGEN__)
-extern I2SDriver I2SD2;
-#endif

+ #if STM32_I2S_USE_SPI2 && !defined(__DOXYGEN__)
+ extern I2SDriver I2SD2;
+ #endif

-#if STM32_I2S_USE_I2S3 && !defined(__DOXYGEN__)
-extern I2SDriver I2SD3;
-#endif

+ #if STM32_I2S_USE_I2S3 && !defined(__DOXYGEN__)
+ extern I2SDriver I2SD3;
+ #endif
 ========

 The first check seems to be fine, but second one should be #if STM32_I2S_USE_SPI3 not #if STM32_I2S_USE_I2S3 I guess.
    • status: open --> closed-fixed
    • assigned_to: Giovanni Di Sirio
    • Priority: 5 --> 4
     

  • Giovanni Di Sirio

    Giovanni Di Sirio - 2014-04-04

    Fixed in repository, thanks.

     

Log in to post a comment.

veeam logo