#306 git master fails to build on Qt 5.12

[Luigi Baldoni]

As per subject, in order to test the fix for #305 I tried building from the github repository and ended up with:

cd /home/abuild/rpmbuild/BUILD/chessx-1.5.6+git20211120.6a2fb5ca/build/src && /usr/bin/c++  -DQT_CORE_LIB -DQT_DEPRECATED_WARNINGS -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -DUSE_C11 -DUSE_SCID -I/home/abuild/rpmbuild/BUILD/chessx-1.5.6+git20211120.6a2fb5ca/build/src/database_autogen/include -I/home/abuild/rpmbuild/BUILD/chessx-1.5.6+git20211120.6a2fb5ca/src/database -I/home/abuild/rpmbuild/BUILD/chessx-1.5.6+git20211120.6a2fb5ca/src/gui -I/home/abuild/rpmbuild/BUILD/chessx-1.5.6+git20211120.6a2fb5ca/src/guess -I/home/abuild/rpmbuild/BUILD/chessx-1.5.6+git20211120.6a2fb5ca/src/database/scid -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/qt5/QtNetwork  -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -g -DNDEBUG -O2 -g -DNDEBUG   -fPIC -std=c++11 -o CMakeFiles/database.dir/database/filtermodel.cpp.o -c /home/abuild/rpmbuild/BUILD/chessx-1.5.6+git20211120.6a2fb5ca/src/database/filtermodel.cpp
/home/abuild/rpmbuild/BUILD/chessx-1.5.6+git20211120.6a2fb5ca/src/database/filtermodel.cpp: In static member function 'static QStringList FilterModel::additionalTags()':
/home/abuild/rpmbuild/BUILD/chessx-1.5.6+git20211120.6a2fb5ca/src/database/filtermodel.cpp:106:64: error: 'SkipEmptyParts' is not a member of 'Qt'
     QStringList tags = addTags.split(QRegExp("[^a-zA-Z]"), Qt::SkipEmptyParts);
                                                                ^~~~~~~~~~~~~~
make[2]: *** [src/CMakeFiles/database.dir/build.make:356: src/CMakeFiles/database.dir/database/filtermodel.cpp.o] Error 1
make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/chessx-1.5.6+git20211120.6a2fb5ca/build'

[Jens Nissen]

Qt moved the SplitBehaviorFlags from QString to Qt namespace in t 5.14.
Makes me wonder how to handle this without cluttering the code in #ifdef sequences and at the same time get somewhat closer to Qt6, where all these obsolete things are dropped.

[Ondrej Mosnacek]

You could create a compat header like quazip does and include it where needed:
https://github.com/stachenov/quazip/blob/master/quazip/quazip_qt_compat.h#L45-L51

[Jens Nissen]

Note to myself: Use "SkipEmptyParts" instead of Qt:SkipEmptyParts and include qt6compat.h