Menu

#6 Sum files are broken

open-accepted
GUI (2)
5
2011-03-31
2011-03-30
Anonymous
No

In the latest alpha, when saving and loading a sum file, I always get "Unknown checksum file type!". Perhaps the file is not being written correctly? Sample:

; CRC-32 sums generated by version
;
; Created 3/30/2011 12:54:14 PM
test.txt 6b4070be

Discussion

  • Kimmo Varis

    Kimmo Varis - 2011-03-31

    Yep. For some reason the loading itself works (all included unit tests pass). But when trying to load same file the tests used from actual program it shows the error. I'll look at this.

    Thanks for reporting!

     
  • Kimmo Varis

    Kimmo Varis - 2011-03-31
    • assigned_to: nobody --> kimmov
    • status: open --> open-accepted
     
  • Kimmo Varis

    Kimmo Varis - 2011-04-02

    Ok, now I know what is happening. Version 0.7 added a check that files in the checksum file exist when loading the checksum file. If the files in checksum file are not found then error is printed. But unfortunately the error message was not updated and is just wrong and confusing.

    Also, thinking about this more I don't think it is actually a good idea to check file existence when loading the file. It should can be done, but only lead to warning, not failing the file load. We really should check the existence when accessing the files.