From: Branden A. <b.m...@gm...> - 2015-05-04 00:32:23
|
I think the conversation ended with asking what the expected behavior should be. I think that there is agreement that making the calls no-ops is acceptable. I'll make that change and add relevant unit tests to Check. Thanks for the reminder, I had forgotten. (: - Branden On Sat, May 2, 2015 at 12:49 AM, Vincent Torri <vt...@un...> wrote: > > Hey > > what is the status of that report ? > > thank you > > Vincent Torri > > On Mon, 2 Feb 2015, Chris Pickett wrote: > > > On Mon, February 2, 2015 4:33 am, Fredrik Hugosson wrote: > > > >> OK, so what you would actually need to fix that exact problem is that we > >> have the function available but it does not do anything. Is that a > correct > >> observation? > > > > Probably just protect the body with: > > > > #if defined(HAVE_FORK) && HAVE_FORK==1 > > ... > > #endif > > > > You might need to mark the parameters as unused. I'm pretty sure there > > are examples of setting unused attributes elsewhere if you grep -ir > unused > > * from the trunk. > > > > Vincent, if you come across this kind of thing with another project, you > > can always write a wrapper function in your own codebase so that you only > > need one set of #ifdef/#endif. But I agree Check is the right place to > > fix it. > > > > Chris > > > > > > > ------------------------------------------------------------------------------ > One dashboard for servers and applications across Physical-Virtual-Cloud > Widest out-of-the-box monitoring support with 50+ applications > Performance metrics, stats and reports that give you Actionable Insights > Deep dive visibility with transaction tracing using APM Insight. > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > _______________________________________________ > Check-users mailing list > Che...@li... > https://lists.sourceforge.net/lists/listinfo/check-users > |