From: Robert C. <ro...@ro...> - 2009-05-09 02:12:10
|
On Sat, 2009-05-09 at 09:38 +1000, Robert Collins wrote: > On Fri, 2009-05-08 at 10:06 +0200, Fredrik Hugosson wrote: > > > Also make sure that make check and make distcheck works for both cases. > > And add yourself as an author in the right places (AUTHORS and > > documentation at least) if you are not there already. > > make check and distcheck hang/fail for me before the subunit patch is > applied :(. I'm double checking to verify it doesn't make that worse, > but I'll land it after that. No changes with/without the patch applied, so I've committed it. I found a couple of small VPATH related bugs while testing this - r541 and r542. I just committed those as they were simple and clearly correct. (Is this ok?) r543 has the subunit support added, which is precisely the previous reviewed patch, with one tiny additional tweak - I also had a VPATH build bug in test_output.sh. I've tested it on all the platforms I have, but thats pretty homogeneous I'm afraid. -Rob |