#84 Restore reliable Messenger notifications

[Anonymous]

Originally created by: kristofferR

Summary

• add a conversation-row notification path for messages where Facebook never constructs a Web Notification
• prime and track unread preview signatures without startup or virtualization false positives
• correlate page and row signals by sender and preview text to avoid duplicate or cross-conversation cancellation
• preserve mute, hidden-preview, avatar, refresh, and notification-click behavior

Root cause

Messenger can update its unread title and conversation row without invoking the page Notification API. Carrier previously depended entirely on that invocation, so the native notification pipeline never received real messages in this state.

The row-driven path follows the current Caprine/Wheemer approach while using Carrier's stable role, thread-link, and computed unread-state selectors instead of hashed Facebook classes. The page API remains an optional higher-fidelity signal when Facebook provides it.

Validation

• verified a real incoming message delivered correctly from a Developer-ID-signed v1.2.4 build
• bun run check (47 tests, lint, typecheck, generated bundle verification)
• cargo fmt
• cargo clippy --all-targets -- -D warnings
• cargo test --lib (57 tests)
• local CodeRabbit preflight findings addressed

Ref [#80]

[Anonymous]

Originally posted by: kristofferR

@codex review

[Anonymous]

Originally posted by: kristofferR

@coderabbitai review

[Anonymous]

Originally posted by: coderabbitai[bot]

✅ Action performed

Review finished. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[Anonymous]

Originally posted by: coderabbitai[bot]

[!WARNING]

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 28 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3250bf7e-2fde-4266-a720-905e9e6c7f9d

📥 Commits

Reviewing files that changed from the base of the PR and between [8fd0e1] and d135f14e5052e1f2b157bd3036405d2e8e415f46.

📒 Files selected for processing (4)

• inject/src/messenger/features/notifications.ts
• inject/src/messenger/lib/notification-fallback.test.ts
• inject/src/messenger/lib/notification-fallback.ts
• src-tauri/inject/messenger.js

✨ Finishing Touches

🧪 Generate unit tests (beta)

- [ ] Create PR with unit tests - [ ] Commit unit tests in branch `codex/fix-80-notifications`

---

_{Comment @coderabbitai help to get the list of available commands.}

[Anonymous]

Ticket changed by: kristofferR

• status: open --> closed