Menu ▾ ▴

#79 Remove the do-not-disturb schedule setting

closed
nobody
None
2026-07-10
2026-07-10
Anonymous
No

Originally created by: kristofferR

The in-app DND window duplicated what the OS already does system-wide (macOS Focus, Windows Focus Assist, freedesktop DND) and was one more path that silently dropped notifications while the unread badge kept updating — exactly the confusing "badge but no banner" symptom. The OS owns notification suppression now.

  • Removes the dnd_start/dnd_end settings, the time-picker rows in the Settings window, the page-side dndActive check, and the Rust-side wall-clock window check; stale keys in existing settings.json files are ignored on load
  • Drops the chrono dependency (only used for the DND check)
  • Adds a completion handler to addNotificationRequest on macOS so a rejected delivery (revoked authorization, malformed content) is logged instead of vanishing — the delivery-step counterpart of the authorization logging from [#76]

Gate: clippy clean, 56 Rust + 38 bun tests pass, inject bundles rebuilt.

https://claude.ai/code/session_012tR6tuVFohNEd4gu4sGD1Z

Related

Tickets: #76
Tickets: #80

Discussion

  • Anonymous

    Anonymous - 2026-07-10

    Originally posted by: kristofferR

    @coderabbitai review

     
  • Anonymous

    Anonymous - 2026-07-10

    Originally posted by: coderabbitai[bot]

    ✅ Action performed Review finished. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
     
  • Anonymous

    Anonymous - 2026-07-10

    Originally posted by: coderabbitai[bot]

    [!WARNING]

    Review limit reached

    You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

    Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

    Next review available in: 40 minutes

    Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
    You're only billed for reviews past your plan's rate limits ($0.25/file).


    How can I continue?

    After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

    To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.


    How do review limits work?

    CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

    For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

    Please refer docs for additional details.


    Review details


    ⚙️ Run configuration

    Configuration used: Path: .coderabbit.yaml

    Review profile: ASSERTIVE

    Plan: Pro

    Run ID: 8a99a02a-3935-4529-9402-aca5a4264a3a


    📥 Commits

    Reviewing files that changed from the base of the PR and between [2fe90d] and 047711fa5d9ca1b8647f338b5e8971e62f280714.


    ⛔ Files ignored due to path filters (1)

    • src-tauri/Cargo.lock is excluded by !**/*.lock


    📒 Files selected for processing (12)

    • dist/settings.html
    • inject/src/messenger/features/notifications.ts
    • inject/src/messenger/lib/dnd.test.ts
    • inject/src/messenger/lib/dnd.ts
    • inject/src/types.d.ts
    • src-tauri/Cargo.toml
    • src-tauri/inject/mcp-bridge.js
    • src-tauri/inject/messenger.js
    • src-tauri/src/lib.rs
    • src-tauri/src/macos/notifications.rs
    • src-tauri/src/notifications.rs
    • src-tauri/src/settings.rs
    ✨ Finishing Touches
    🧪 Generate unit tests (beta) - [ ] Create PR with unit tests - [ ] Commit unit tests in branch `remove-dnd-schedule`

    Comment @coderabbitai help to get the list of available commands.

     

    Related

    Commit: [2fe90d]

  • Anonymous

    Anonymous - 2026-07-10

    Ticket changed by: kristofferR

    • status: open --> closed
     

Log in to post a comment.