Chatpane / Tickets / #70 Typed build + lint + unit-test toolchain for inject/ scripts

Originally posted by: coderabbitai[bot]

📝 Walkthrough

## Walkthrough This PR migrates injected Facebook Messenger/panel scripts from a single hand-written JS file into a typed Bun/TypeScript source tree (`inject/src/`) bundled via esbuild into `src-tauri/inject`. It adds CI/toolchain (Biome, tsconfig, build script), a shared bridge/types layer, reusable lib utilities with tests, and numerous feature modules (hide-names, login-tidy, cookie-consent, notifications, unread-badge, zoom, shortcuts, telemetry blocking, etc.) wired through a single Messenger entrypoint. ### Changes **Injected Script TypeScript Migration** |Layer / File(s)|Summary| |---|---| |**Build tooling, CI, and config**
`.github/workflows/ci.yml`, `package.json`, `biome.jsonc`, `tsconfig.json`, `tsconfig.test.json`, `inject/build.ts`, `AGENTS.md`, `README.md`|New CI `inject` job runs lint/typecheck/tests/build and fails on bundle drift; package.json adds build/lint/typecheck/check scripts and dev dependencies; Biome and TypeScript configs are introduced; `inject/build.ts` bundles typed sources into `src-tauri/inject` via esbuild; docs describe the new pipeline.| |**Bridge helpers and ambient types**
`inject/src/messenger/bridge.ts`, `inject/src/types.d.ts`|Adds `invoke`, `toast`, `diag`, `openUrl` bridge functions and ambient typings for `CarrierSettings`, `Window`, `XMLHttpRequest`, `Element`, `Document` extensions.| |**Shared lib utilities and tests**
`inject/src/messenger/lib/*.ts`, `inject/src/messenger/lib/*.test.ts`|Adds pure helpers for color parsing, DND windows, download filenames, emoji glyph detection, link classification, privacy/identity text heuristics, telemetry URL blocking, thread id parsing, unread count parsing, and zoom clamping, each with unit tests.| |**Core UX features**
`inject/src/messenger/features/{conversation-actions,shortcuts,thread-nav,link-handling,zoom,media-viewer,fullscreen,spellcheck}.ts`|Implements conversation navigation, keyboard shortcuts, thread opening, external link handling, page zoom, media zoom/pan viewer, a fullscreen polyfill, and spellcheck toggling.| |**Privacy and appearance features**
`inject/src/messenger/features/{hide-names,force-theme,login-tidy,cookie-consent}.ts`|Implements identity-hiding DOM scanning, forced theme enforcement, logged-out login page tidying, and optional cookie-decline automation.| |**System integration features**
`inject/src/messenger/features/{notifications,unread-badge,recent-threads,telemetry,media-permissions,download-anchors,context-menu,selector-health,auto-refresh,system-emoji}.ts`|Implements native notification bridging, Dock/taskbar unread badge sync, recent-thread scraping, telemetry request blocking, media permission warnings, download interception, a custom context menu, selector health monitoring, auto-refresh recovery, and system emoji replacement.| |**Entrypoint wiring and regenerated bundles**
`inject/src/messenger/index.ts`, `inject/src/panel/index.ts`, `src-tauri/inject/panel.js`|Wires all feature initializers into a single `main()` guarded by top-frame checks; panel entrypoint exposes toast/update/settings bridge globals; regenerated `panel.js` reflects the new bundled output.| **Estimated code review effort:** 4 (Complex) | ~75 minutes ### Sequence Diagram(s) :::mermaid sequenceDiagram participant Window participant MessengerIndex as inject/src/messenger/index.ts participant Features as Feature Initializers participant Bridge as bridge.ts (invoke) participant Tauri as Tauri Backend Window->>MessengerIndex: load script, check window.top===window.self MessengerIndex->>Features: call init*() in fixed order Features->>Bridge: invoke("plugin:event|emit", ...) Bridge->>Tauri: forward via __TAURI_INTERNALS__.invoke Tauri-->>Bridge: response/ack Bridge-->>Features: resolved/rejected promise **Possibly related issues** - [kristofferR/Carrier#48](https://github.com/kristofferR/Carrier/issues/48): Implements the same typed Bun/esbuild build/lint/test toolchain for `inject/` scripts described in this issue, including CI wiring. **Possibly related PRs** - [[kristofferR/Carrier#1](https://github.com/kristofferR/Carrier/issues/1)](https://github.com/kristofferR/Carrier/pull/1): Both PRs modify `src-tauri/inject/panel.js`'s `__carrierToast`, `__carrierCheckUpdates`, and `__carrierToggleSettings` functions. - [[kristofferR/Carrier#22](https://github.com/kristofferR/Carrier/issues/22)](https://github.com/kristofferR/Carrier/pull/22): The new `initHideNames()` implementation corresponds to the same "Hide Names & Avatars" feature and `data-carrier-hide-names` mechanism. - [[kristofferR/Carrier#63](https://github.com/kristofferR/Carrier/issues/63)](https://github.com/kristofferR/Carrier/pull/63): Introduces the same `clampZoom`/`applyZoom`/`initZoom` page-zoom logic later wired to `carrier:zoom` settings.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

✨ Finishing Touches

📝 Generate docstrings

- [ ] Create stacked PR - [ ] Commit on current branch

🧪 Generate unit tests (beta)

- [ ] Create PR with unit tests - [ ] Commit unit tests in branch `typed-inject-toolchain`

_{Comment @coderabbitai help to get the list of available commands.}

Typed build + lint + unit-test toolchain for inject/ scripts

Facebook Messenger on your desktop, without the Facebook clutter

Milestone

Searches

Help

#70 Typed build + lint + unit-test toolchain for inject/ scripts

What changed

Fidelity checks

Summary by CodeRabbit

Related

Discussion