Menu ▾ ▴

#459 fix: carry Carrier's logs, macOS preferences and zoom key over to Chatpane

closed
nobody
None
5 days ago
5 days ago
Anonymous
No

Originally created by: kristofferR

On two machines that upgraded to 3.1.0, the first launch moved Carrier's data folders but left three things under the old name:

  • Carrier.log (and rotated Carrier_*.log) in the moved log folder. Log rotation only touches Chatpane* files, so these stayed forever.
  • On macOS, Carrier's preferences domain (io.github.kristofferr.carrier), which holds the folder file dialogs last showed and panel sizes.
  • The page kept writing the zoom level to the carrier:zoom localStorage key on every zoom change.

Fix:

  • identity.rs renames Carrier's log files in Chatpane's folders to Chatpane*.log, so they continue as Chatpane's log and rotate away normally. On macOS it merges Carrier's preferences into Chatpane's (Chatpane's own values win) and removes the old domain. Both also run on launches after the folders already moved, so installs that are already on 3.1.0 get them too.
  • zoom.ts no longer mirrors the zoom to carrier:zoom. Settings has held the zoom for a long time; the key is read once as the migration source for pre-settings installs and then removed.
  • The blank-window debugging guide gets the new Linux log path.

The rest of the Carrier migration code goes in January 2027 (see [#455]).

Summary by CodeRabbit

  • Bug Fixes
  • Preserved existing zoom settings during migration, applying an older saved zoom level only when the current setting is still at its default.
  • Migrated eligible legacy log files and macOS preferences to Chatpane while keeping existing Chatpane preference values and logs.
  • Documentation
  • Updated troubleshooting instructions to use Chatpane’s log name and Linux log-folder location.

Related

Tickets: #455

Discussion

  • Anonymous

    Anonymous - 5 days ago

    Originally posted by: kristofferR

    @coderabbitai review

     
  • Anonymous

    Anonymous - 5 days ago

    Originally posted by: coderabbitai[bot]

    Action not completed

    Pull request is closed. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
     
  • Anonymous

    Anonymous - 5 days ago

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review Summary: ✅ Completed This comment shows the latest Codex review activity on this pull request. | Review | Status | Commit | Review trigger | | --- | --- | --- | --- | | 📝 **Code Review** | ✅ **Completed** <relative-time datetime="2026-11-09T14:45:23.075459Z">2026-11-09T14:45:23.075459Z</relative-time> | `9fd1825` | Manual request |
    ℹ️ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review" or "@codex security review". Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
     
  • Anonymous

    Anonymous - 5 days ago

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review: Didn't find any major issues. What shall we delve into next?

    Reviewed commit: 9fd1825dd4

    ℹ️ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
     
  • Anonymous

    Anonymous - 5 days ago

    Ticket changed by: kristofferR

    • status: open --> closed
     

Log in to post a comment.