Chatpane / Tickets / #439 feat: notification, sound and layout improvements from the fMess review

Originally posted by: chatgpt-codex-connector[bot]

Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request. | Review | Status | Commit | Review trigger | | --- | --- | --- | --- | | 📝 **Code Review** | ✅ **Completed** <relative-time datetime="2026-11-08T09:05:17.411563Z">2026-11-08T09:05:17.411563Z</relative-time> | `7a8a2af` | Manual request |

ℹ️ About Codex in GitHub

[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review" or "@codex security review". Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Originally posted by: coderabbitai[bot]

<picture> Explain Change → </picture>

[!WARNING]

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 44 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

<picture></picture> Run configuration

Source mode: Auto

Repository: kristofferR/Carrier

Branch: t3/competitive-gap-review

File: .coderabbit.yaml (github.com)

Commit: 7a8a2af

Layers: Repository YAML

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 76eae4e4-0191-422f-a7cd-aad9ec43dfbd

<picture></picture> Commits

Reviewing files that changed from the base of the PR and between [a49771] and 7a8a2af9be7ff48240811dbbeb3c12a67a731554.

<picture></picture> Files selected for processing: 1

src-tauri/inject/mcp-bridge.js

Walkthrough

The pull request adds Messenger features for sound and notification handling, pane resizing, encrypted-chat read-ahead, media zoom, voice-clip Escape handling, and chat presentation. It also adds Tauri persistence and window updates for pane widths, plus a bridge probe for feature state and actions. **Changes: Sound and notification handling** |Layer / File(s)|Summary| |:---|:---| |**Messenger sound routing**
`inject/src/messenger/lib/messenger-sounds.ts`, `inject/src/messenger/features/messenger-sounds.ts`, `inject/src/messenger/features/facebook-modules.ts`, `inject/src/messenger/lib/messenger-sounds.test.ts`|Sound modules apply message-sound policy and route eligible non-looping audio through Web Audio, with native playback fallback.| |**Old-message detection and stale state**
`inject/src/messenger/lib/page-notifications.ts`, `inject/src/messenger/lib/page-notifications.test.ts`|Message timestamps and read watermarks identify old notifications. The page message index records stale IDs and exposes stale-tag checks.| |**Notification delivery and sound state**
`inject/src/messenger/features/notifications.ts`, `src-tauri/src/notifications.rs`|Native notification payloads carry silent state, stale page notifications follow the suppression path, and avatar visibility is handled separately from preview visibility.| **Pane resizing and persistence** |Layer / File(s)|Summary| |:---|:---| |**Pane width rules**
`inject/src/messenger/lib/pane-resize.ts`, `inject/src/messenger/lib/pane-resize.test.ts`, `inject/src/types.d.ts`|Pane width values are sanitized and bounded. Helpers calculate resize edges, drag widths, limits, and CSS; tests cover these calculations.| |**Resize interaction**
`inject/src/messenger/features/pane-resize.ts`, `inject/src/messenger/lib/pane-gradient.browser.test.ts`|The page applies stored widths, supports pointer dragging and double-click resets, and emits changed widths. Browser tests cover drag termination and gradient detection.| |**Persisting and distributing widths**
`src-tauri/src/pane_widths.rs`, `src-tauri/src/settings.rs`, `src-tauri/src/commands.rs`, `src-tauri/src/lib.rs`, `src-tauri/src/window.rs`|Tauri stores pane widths, preserves them during ordinary settings saves, and pushes updates to Messenger windows.| **Encrypted chat read-ahead** |Layer / File(s)|Summary| |:---|:---| |**Thread selection and timing**
`inject/src/messenger/lib/read-ahead.ts`, `inject/src/messenger/lib/read-ahead.test.ts`|Selection filters eligible encrypted inbox threads and excludes the open thread and duplicates. Timing helpers enforce result limits and minimum gaps.| |**Preload scheduling and execution**
`inject/src/messenger/features/read-ahead.ts`|The initializer checks runtime conditions, loads Messenger APIs, preloads selected threads with timeouts, and schedules runs after startup and activity events.| **Media viewer zoom** |Layer / File(s)|Summary| |:---|:---| |**Zoom math and boundaries**
`inject/src/messenger/lib/media-zoom.ts`, `inject/src/messenger/lib/media-zoom.test.ts`|Shared utilities convert wheel input to scale factors and keep a selected point anchored within scale limits.| |**Viewer zoom controls**
`inject/src/messenger/features/media-viewer.ts`|The viewer delegates wheel and double-click zoom to shared utilities, tracks Ctrl state, and adds WebKit gesture entry, updates, and exit behavior.| **Voice-clip Escape handling** |Layer / File(s)|Summary| |:---|:---| |**Escape eligibility and cancel icon**
`inject/src/messenger/lib/composer-keys.ts`, `inject/src/messenger/lib/composer-keys.test.ts`|Helpers identify the voice-clip cancel icon and define the conditions for handling Escape.| |**Capture-phase cancel action**
`inject/src/messenger/features/composer-keys.ts`|The document capture handler checks for a visible cancel button and clicks it when Escape is eligible.| **Chat presentation and selection** |Layer / File(s)|Summary| |:---|:---| |**Outgoing bubble gradient**
`inject/src/messenger/lib/chat-gradient.ts`, `inject/src/messenger/lib/chat-gradient.test.ts`, `inject/src/messenger/features/chat-gradient.ts`|The feature discovers outgoing bubble classes from accessible stylesheets and applies generated gradient CSS.| |**Selection and scrollbar behavior**
`inject/src/messenger/features/selection.ts`, `inject/src/messenger/lib/scrollbars.ts`, `inject/src/messenger/lib/scrollbars.test.ts`, `inject/src/messenger/features/scrollbars.ts`, `src-tauri/inject/messenger.css`|The page tracks Messenger paths for selection controls, measures scrollbar style, and positions a scroll indicator. CSS styles selection, scrollbars, the indicator, and fully sized main-pane images.| |**Feature registration and platform setup**
`inject/src/messenger/index.ts`, `src-tauri/src/macos/mod.rs`, `src-tauri/src/macos/scrollbars.rs`, `src-tauri/src/lib.rs`|Messenger registers the new feature initializers, and macOS startup requests overlay scrollbars before creating webviews.| **Messenger feature probe** |Layer / File(s)|Summary| |:---|:---| |**Probe command and actions**
`src-tauri/inject/mcp-bridge.js`|The bridge dispatches the optional probe command and returns feature diagnostics or action results, including errors from rejected asynchronous actions.| **Estimated code review effort:** 4 (Complex) | ~60 minutes **Change:** Feature **Possibly related issues** - [[kristofferR/Carrier#349](https://github.com/kristofferR/Carrier/issues/349)](https://github.com/kristofferR/Carrier/issues/349): The PR changes Messenger sound handling and duplicate message rings, which match the tracker’s notification behavior. - [[kristofferR/Carrier#437](https://github.com/kristofferR/Carrier/issues/437)](https://github.com/kristofferR/Carrier/issues/437): The PR changes sound behavior related to one sound per message, Do Not Disturb, and Messenger’s sound setting. **Possibly related PRs** - [[kristofferR/Carrier#378](https://github.com/kristofferR/Carrier/issues/378)](https://github.com/kristofferR/Carrier/pull/378): This PR provides the `notificationsGloballyMuted` contract used by the new Messenger sound and notification logic.

Pre-merge checks: ^{<picture></picture>} 3 · ^{<picture></picture>} 2

^{<picture></picture>} Failed checks: 2 warnings | Check name | Status | Explanation | Resolution | | :---------------- | :----------------------------------------------------------------------------------------------: | :-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | | Docstring Coverage | ![Warning](https://storage.googleapis.com/coderabbit_public_assets/pre-merge-checks-warning.svg) | Docstring coverage is 58.18% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… | Write docstrings for the functions missing them to satisfy the coverage threshold. | | Description check | ![Warning](https://storage.googleapis.com/coderabbit_public_assets/pre-merge-checks-warning.svg) | The description covers the change in substantial detail: notification and sound behavior, pane resizing, encrypted-chat read-ahead, layout and polish items, and the fMess MIT attribution. It also list… | Add the template's required sections: a '## Summary' heading that wraps the problem and change text, and an 'AI models used:' line. State the models and versions used to create or edit code, tests, or PR text, or write 'None' if no AI was u… |

^{<picture></picture>} Passed checks: 3 passed

| Check name | Status | Explanation | | :------------------------ | :--------------------------------------------------------------------------------------------: | :-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | Title check | ![Passed](https://storage.googleapis.com/coderabbit_public_assets/pre-merge-checks-passed.svg) | The title "feat: notification, sound and layout improvements from the fMess review" matches the changeset. The diff covers notification suppression for old news and silent delivery, Web Audio routing … | | Linked Issues check | ![Passed](https://storage.googleapis.com/coderabbit_public_assets/pre-merge-checks-passed.svg) | Check skipped because no linked issues were found for this pull request. | | Out of Scope Changes check | ![Passed](https://storage.googleapis.com/coderabbit_public_assets/pre-merge-checks-passed.svg) | Check skipped because no linked issues were found for this pull request. |

Full details: Title check

**Explanation** The title "feat: notification, sound and layout improvements from the fMess review" matches the changeset. The diff covers notification suppression for old news and silent delivery, Web Audio routing for Messenger sounds, pane resizing, read-ahead, scrollbars, gradient handling, and Escape handling for voice clips. The title names the three main areas but omits read-ahead, scrollbars, and the Escape change. It also includes the phrase 'from the fMess review', which describes the source of the work rather than the change itself. The title is broad, but it is related to the changeset and is not misleading.

Full details: Docstring Coverage

**Explanation** Docstring coverage is 58.18% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 55 functions across 38 files. **Resolution** Write docstrings for the functions missing them to satisfy the coverage threshold.

Full details: Description check

**Explanation** The description covers the change in substantial detail: notification and sound behavior, pane resizing, encrypted-chat read-ahead, layout and polish items, and the fMess MIT attribution. It also lists the checks run and the live verification done. It does not follow the repository template, which requires a '## Summary' heading, an 'AI models used' field, and an optional reasoning-levels field. The author never states whether AI helped write the code or PR text, so the required AI-models field is missing. The description also does not say that the test plan is partly unfinished beyond a short list of manual checks. **Resolution** Add the template's required sections: a '## Summary' heading that wraps the problem and change text, and an 'AI models used:' line. State the models and versions used to create or edit code, tests, or PR text, or write 'None' if no AI was used. Optionally add the 'Reasoning levels' line, or write 'Reasoning levels: Unavailable (not exposed by tool)' if AI was used and the tool does not expose it.

Finishing Touches

Generate docstrings

- [ ] Commit to this branch - [ ] Create a new PR

Generate unit tests (beta)

- [ ] Commit to this branch - [ ] Create a new PR

[ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

[!WARNING]
Review coverage is incomplete: 1 file could not be fully reviewed. Findings from completed review steps are included; see review info for details.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Commit: [a49771]

feat: notification, sound and layout improvements from the fMess review

Facebook Messenger on your desktop, without the Facebook clutter

Milestone

Searches

Help

#439 feat: notification, sound and layout improvements from the fMess review

What changed

Testing

Summary by CodeRabbit

Related

Discussion

Review limit reached

Related