feat(settings): cards layout and a direct light/dark app icon picker
Facebook Messenger on your desktop, without the Facebook clutter
Brought to you by:
kristoffer-r
Menu
▾
▴
#438 feat(settings): cards layout and a direct light/dark app icon picker
closed
nobody
None
7 days ago
7 days ago
Anonymous
No
Originally created by: kristofferR
Settings › Appearance mixed four layouts on one tab, and the other tabs put checkboxes and selects to the left of their labels, so nothing lined up. The app icon was two small style pills plus a separate Light / Dark / Match theme switch: you never saw the icon you would get, and style and variant were picked in two places.
Cards and one row layout (Ref [#422])
- Every tab is a stack of cards. A row has its label and a one-line hint on the left and its control on the right edge. On/off settings are switches on every tab, and selects share one style.
- Appearance opens with a compact card (Page zoom, Hide Top Menu on Windows/Linux, Title bar on Linux, System Emoji, Nicknames). Theme follows with System / Light / Dark in its header and the themes folder link and custom.css note under the grid. Accent color and Message font come next, then App icon.
- The two nickname checkboxes become one select over the same four
nickname_scopestates. - Stop Media Autoplay moves to General.
App icon (Ref [#423])
- Four tiles: Color, Color dark, Mono, Mono dark. The tile you click is the icon you get.
- "Different icon in dark mode" adds a second row, so light and dark mode each get their own pick, in any combination. Dark mode is what Match theme followed before.
app_iconandapp_icon_darkreplaceapp_icon_styleandapp_icon_variant. Old settings migrate on load: a fixed variant keeps that icon, and Match theme becomes the style's light and dark pair. The old keys are never written again.- Platform behaviour (macOS Dock icon, Windows/Linux window icons, the separately drawn badge) is unchanged.
Testing
cargo fmt, clippy,cargo test --lib(new tests for the migration and for choosing the icon) andbun run checkpass.- Settings rendered in light and dark at the default 900×720 window with a stubbed IPC: the Theme header and first row of theme cards sit above the fold. The nickname select round-trips all four values. Switches, the theme switch, zoom, the icon tiles and the dark-mode switch save the right keys.
- Not yet checked by hand in the real Settings window on macOS, Windows and Linux.
Related
Originally posted by: kristofferR
@coderabbitai review
Originally posted by: coderabbitai[bot]
Action not completed
Review rate limited. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
Originally posted by: coderabbitai[bot]
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Share
- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Related
Commit: [fecfa8]
Originally posted by: chatgpt-codex-connector[bot]
Codex Review Summary: ✅ Completed
This comment shows the latest Codex review activity on this pull request. | Review | Status | Commit | Review trigger | | --- | --- | --- | --- | | 📝 **Code Review** | ✅ **Completed** <relative-time datetime="2026-11-08T07:10:43.325229Z">2026-11-08T07:10:43.325229Z</relative-time> | `734b7ac` | Manual request |ℹ️ About Codex in GitHub
[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review" or "@codex security review". Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
Originally posted by: chatgpt-codex-connector[bot]
Codex Review: Didn't find any major issues. Hooray!
Reviewed commit:
734b7ace9aℹ️ About Codex in GitHub
[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Ticket changed by: kristofferR