Menu ▾ ▴

#435 feat(appearance): remove the High Contrast theme

closed
nobody
None
7 days ago
7 days ago
Anonymous
No

Originally created by: kristofferR

The built-in High Contrast theme isn't wanted, and it brought a second mechanism with it: whenever the system asked for more contrast, it took over from the chosen theme (through prefers-contrast on macOS and Windows, and the settings portal's contrast key on Linux).

This removes the theme and that takeover:

  • src-tauri/themes/high-contrast.css and its built-in entry are gone, along with its Settings preview.
  • The appearance script now creates three style elements (theme, accent, font) with no media switching.
  • The Linux portal contrast watcher and the linux_high_contrast state are removed.

Themes have not shipped in a release yet, so there is no settings migration. A saved high-contrast id resolves to no theme CSS, which is Messenger's own look.

Ref [#405], Ref [#434]

Summary by CodeRabbit

  • Appearance
  • The built-in High Contrast theme is no longer available.
  • The app no longer switches to a high-contrast appearance in response to the desktop’s contrast setting.
  • Theme previews now use the selected theme’s own colors, or the default dark preview when those colors aren’t available.

Related

Tickets: #405
Tickets: #434

Discussion

  • Anonymous

    Anonymous - 7 days ago

    Originally posted by: coderabbitai[bot]

    Action performed

    Review finished. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
     
  • Anonymous

    Anonymous - 7 days ago

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review Summary: ✅ Completed This comment shows the latest Codex review activity on this pull request. | Review | Status | Commit | Review trigger | | --- | --- | --- | --- | | 📝 **Code Review** | ✅ **Completed** <relative-time datetime="2026-11-08T06:41:58.209675Z">2026-11-08T06:41:58.209675Z</relative-time> | `d2bd170` | Manual request |
    ℹ️ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review" or "@codex security review". Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
     
  • Anonymous

    Anonymous - 7 days ago

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review: Didn't find any major issues. Delightful!

    Reviewed commit: d2bd1704b8

    ℹ️ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
     
  • Anonymous

    Anonymous - 7 days ago

    Originally posted by: coderabbitai[bot]

    <picture>Explain Change →</picture>

    Walkthrough

    The built-in High Contrast theme, its appearance handling, and its dark preview mapping were removed. Linux no longer monitors the desktop contrast setting or stores a high-contrast state. Color-scheme monitoring remains. **Changes: High Contrast removal** |Layer / File(s)|Summary| |:---|:---| |**Remove High Contrast from appearance**
    `src-tauri/src/themes.rs`, `src-tauri/themes/high-contrast.css`, `dist/settings.html`|The appearance payload and injected styles no longer include High Contrast styles or media-query handling. The High Contrast stylesheet and dark preview mapping are removed. Tests and module documentation are updated.| |**Remove Linux contrast monitoring**
    `src-tauri/src/linux.rs`, `src-tauri/src/settings.rs`, `src-tauri/src/lib.rs`|Linux no longer stores or initializes the high-contrast state or starts a settings-portal contrast watcher. Color-scheme monitoring remains.| **Estimated code review effort:** 3 (Moderate) | ~20 minutes **Change:** Other **Possibly related PRs** - [[kristofferR/Carrier#405](https://github.com/kristofferR/Carrier/issues/405)](https://github.com/kristofferR/Carrier/pull/405): Adds the High Contrast theme, Linux contrast state, and preview mapping that this PR removes.
    Merge Risk: <picture></picture> Minimal · up to d2bd1

    The High Contrast theme and automatic contrast switching are removed as intended. No actionable merge-blocking risk is identified beyond normal checks.
    Pre-merge checks: <picture>Passed</picture> 4 · <picture>Failed</picture> 1

    <picture>Failed</picture> Failed checks: 1 warning | Check name | Status | Explanation | Resolution | | :--------------- | :----------------------------------------------------------------------------------------------: | :-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | | Description check | ![Warning](https://storage.googleapis.com/coderabbit_public_assets/pre-merge-checks-warning.svg) | The description explains the problem (the built-in High Contrast theme and its prefers-contrast and Linux settings-portal contrast takeover) and the change (theme file and entry removed, three style e… | Add the required '## Summary' heading above the problem and change description. Add the '## AI models used' section and state either the AI model names and versions used to create or edit code, tests, or PR text, or 'None'. Optionally add t… |
    <picture>Passed</picture> Passed checks: 4 passed

    | Check name | Status | Explanation | | :------------------------ | :--------------------------------------------------------------------------------------------: | :-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | Title check | ![Passed](https://storage.googleapis.com/coderabbit_public_assets/pre-merge-checks-passed.svg) | The title "feat(appearance): remove the High Contrast theme" matches the main change. The PR deletes src-tauri/themes/high-contrast.css, removes its built-in theme entry and Settings preview, and remo… | | Docstring Coverage | ![Passed](https://storage.googleapis.com/coderabbit_public_assets/pre-merge-checks-passed.svg) | Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… | | Linked Issues check | ![Passed](https://storage.googleapis.com/coderabbit_public_assets/pre-merge-checks-passed.svg) | Check skipped because no linked issues were found for this pull request. | | Out of Scope Changes check | ![Passed](https://storage.googleapis.com/coderabbit_public_assets/pre-merge-checks-passed.svg) | Check skipped because no linked issues were found for this pull request. |
    Full details: Title check

    **Explanation** The title "feat(appearance): remove the High Contrast theme" matches the main change. The PR deletes src-tauri/themes/high-contrast.css, removes its built-in theme entry and Settings preview, and removes the system-contrast takeover logic in themes.rs, linux.rs, lib.rs, and settings.rs. The title is specific, concise, and follows a conventional commit style.
    Full details: Docstring Coverage

    **Explanation** Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 2 files.
    Full details: Description check

    **Explanation** The description explains the problem (the built-in High Contrast theme and its prefers-contrast and Linux settings-portal contrast takeover) and the change (theme file and entry removed, three style elements without media switching, Linux contrast watcher and linux_high_contrast state removed). It also notes there is no settings migration and what a saved high-contrast id resolves to. However, it does not contain the required 'AI models used' section from the repository template, which is required for contributors other than the repository owner. The 'Reasoning levels' section is optional. The template's Summary heading is also present in spirit but the description does not use the exact '## Summary' heading. **Resolution** Add the required '## Summary' heading above the problem and change description. Add the '## AI models used' section and state either the AI model names and versions used to create or edit code, tests, or PR text, or 'None'. Optionally add the '## Reasoning levels' section if AI was used.
    Finishing Touches

    Generate docstrings

    - [ ] Commit to this branch - [ ] Create a new PR
    Generate unit tests (beta)

    - [ ] Commit to this branch - [ ] Create a new PR
    • [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

    Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

    Share

    - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
     
  • Anonymous

    Anonymous - 7 days ago

    Ticket changed by: kristofferR

    • status: open --> closed
     

Log in to post a comment.