fix(menu): right-clicking a message on macOS opens Carrier's menu
Facebook Messenger on your desktop, without the Facebook clutter
Brought to you by:
kristoffer-r
Menu
▾
▴
#420 fix(menu): right-clicking a message on macOS opens Carrier's menu
closed
nobody
None
7 days ago
7 days ago
Anonymous
No
Originally created by: kristofferR
Right-clicking a message on macOS showed WebKit's own menu (Look Up, Translate, Copy…) instead of Carrier's message menu. macOS selects the word under a right-click before the contextmenu event arrives, and the handler took that selection for one the user made, so it stepped aside for the webview's text menu.
The handler now records whether text was selected when the secondary button went down (right button, or Control-click on macOS). A selection the click itself made is ignored and cleared when Carrier's menu opens; a selection the user made beforehand still gets the webview's menu so Copy copies it.
Found in the 3.0 smoke test: on the final main build the Mac showed WebKit's menu with the word highlighted. Linux (WebKitGTK doesn't select on right-click) worked before and the logic is unchanged there. A signed debug build of this branch is building for a Mac check.
Ref [#367]
Related
Originally posted by: kristofferR
@codex review
Originally posted by: chatgpt-codex-connector[bot]
Codex Review Summary: ✅ Completed
This comment shows the latest Codex review activity on this pull request. | Review | Status | Commit | Review trigger | | --- | --- | --- | --- | | 📝 **Code Review** | ✅ **Completed** <relative-time datetime="2026-11-08T03:48:06.228115Z">2026-11-08T03:48:06.228115Z</relative-time> | `50a1f76` | Manual request |ℹ️ About Codex in GitHub
[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review" or "@codex security review". Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
Originally posted by: chatgpt-codex-connector[bot]
Codex Review: Didn't find any major issues. Another round soon, please!
Reviewed commit:
50a1f7601bℹ️ About Codex in GitHub
[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Ticket changed by: kristofferR