fix(settings): keep the app icon's light and dark switch with the icons
Facebook Messenger on your desktop, without the Facebook clutter
Brought to you by:
kristoffer-r
Menu
▾
▴
#417 fix(settings): keep the app icon's light and dark switch with the icons
closed
nobody
None
7 days ago
7 days ago
Anonymous
No
Originally created by: kristofferR
In Settings → Appearance → App icon, the "Light or dark icon" switch sat at the far right of the section header, away from the Color and Monochrome icons it changes, so the two didn't read as one choice. It also defaulted to Match theme.
The switch now sits in the same row as the icons, whose previews already follow it, in the order Light, Dark, Match theme. Light, the installed icon, is the default (Rust default, sanitize fallback and the Settings fallback), with a unit test that the default never picks the dark icon.
Live-checked on Linux: the row reads Color, Monochrome, then Light | Dark | Match theme, Light is selected by default, and Dark switches both previews and saves dark. Not checked on macOS or Windows.
Ref [#369]
Related
Originally posted by: kristofferR
@codex review
Originally posted by: chatgpt-codex-connector[bot]
Codex Review Summary: ✅ Completed
This comment shows the latest Codex review activity on this pull request. | Review | Status | Commit | Review trigger | | --- | --- | --- | --- | | 📝 **Code Review** | ✅ **Completed** <relative-time datetime="2026-11-08T03:45:27.928750Z">2026-11-08T03:45:27.928750Z</relative-time> | `311854a` | Manual request |ℹ️ About Codex in GitHub
[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review" or "@codex security review". Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
Originally posted by: chatgpt-codex-connector[bot]
Codex Review: Didn't find any major issues. Hooray!
Reviewed commit:
311854a7d7ℹ️ About Codex in GitHub
[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Ticket changed by: kristofferR