fix: tray Log Out and Reset no longer crashes while Carrier is hidden
Facebook Messenger on your desktop, without the Facebook clutter
Brought to you by:
kristoffer-r
Menu
▾
▴
#415 fix: tray Log Out and Reset no longer crashes while Carrier is hidden
closed
nobody
None
7 days ago
7 days ago
Anonymous
No
Originally created by: kristofferR
Choosing Log Out and Reset Carrier… from the tray while Carrier was hidden in the tray aborted the app on Linux before the confirmation appeared. The dialog was parented to the hidden main window. A hidden window has no Wayland surface, so building its window handle panics in tao (NonNull::new_unchecked on a null wl_surface); in a release build that is undefined behavior instead.
Native message dialogs (the log-out confirmation and failure message, Clear Cache, and the macOS New Window prompt) now attach only to a visible window via menu::dialog_parent, and otherwise open on their own.
Live-tested on Omarchy (Hyprland, Wayland) with the final main build: with the window hidden, the tray item crashed Carrier (backtrace in raw_window_handle_rwh_06); with this change the dialog appears unparented, Cancel leaves everything intact, and with the window visible it is still parented. Not tested on macOS or Windows.
Ref [#356]
Related
Originally posted by: kristofferR
@codex review
Originally posted by: chatgpt-codex-connector[bot]
Codex Review Summary: ✅ Completed
This comment shows the latest Codex review activity on this pull request. | Review | Status | Commit | Review trigger | | --- | --- | --- | --- | | 📝 **Code Review** | ✅ **Completed** <relative-time datetime="2026-11-08T03:44:07.459518Z">2026-11-08T03:44:07.459518Z</relative-time> | `ac8ebde` | Manual request |ℹ️ About Codex in GitHub
[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review" or "@codex security review". Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
Originally posted by: chatgpt-codex-connector[bot]
Codex Review: Didn't find any major issues. Delightful!
Reviewed commit:
ac8ebde730ℹ️ About Codex in GitHub
[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Ticket changed by: kristofferR