Menu ▾ ▴

#40 Extend hide names privacy coverage

closed
nobody
None
2026-07-01
2026-07-01
Anonymous
No

Originally created by: kristofferR

Summary

  • Blur Hide Names & Avatars identity surfaces in the conversation list, active thread header, sender labels, reply attribution, avatars, and read receipts.
  • Keep message text readable by marking real Messenger elements and wrapping only leading identity prefixes in previews like Name: message or Name left the group.
  • Add a dev-only sanitized MCP privacy probe and document it in AGENTS.md for future selector/debug work.

Validation

  • cargo fmt
  • cargo clippy --all-targets -- -D warnings
  • cargo test --lib
  • node --check inject/messenger.js
  • node --check inject/mcp-bridge.js
  • git diff --check
  • Built and launched bun run tauri build --debug --features mcp --bundles app
  • Verified with __carrier_mcp_privacy_probe__ plus a visual screenshot check of the running Carrier (debug) app

Ref [#23]

Summary by CodeRabbit

  • New Features
  • Expanded privacy mode to hide names and avatars across more identity surfaces in the main Messenger pane, including conversation rows, active-thread headers, sender labels, and read-receipt visuals.
  • Updated the privacy styling to apply targeted blurs to profile-linked elements while keeping message text, previews, and attached media readable.

  • Documentation

  • Added dev guidance for a safe privacy “selector probe” used to verify Hide Names & Avatars behavior without exposing sensitive content.

Related

Tickets: #23

Discussion

  • Anonymous

    Anonymous - 2026-07-01

    Originally posted by: kristofferR

    @coderabbitai review

     
  • Anonymous

    Anonymous - 2026-07-01

    Originally posted by: coderabbitai[bot]

    ✅ Action performed Review finished. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
     
  • Anonymous

    Anonymous - 2026-07-01

    Originally posted by: coderabbitai[bot]

    Review Change Stack

    📝 Walkthrough ## Walkthrough Extends Messenger hide-names behavior with DOM-based identity markers, matching CSS blur rules, and a sanitized MCP probe for inspecting selector coverage. ### Changes **Hide Names & Avatars privacy flow** |Layer / File(s)|Summary| |---|---| |**DOM marker scanning**
    `src-tauri/inject/messenger.js`|Replaces the simple hide-names toggle with marker-based DOM scanning, wrapping, and observer-managed rescans for identity surfaces.| |**Privacy probe responder**
    `AGENTS.md`, `src-tauri/inject/mcp-bridge.js`|Adds a sentinel `execute-js` probe path that returns sanitized diagnostics instead of evaluating JavaScript, and documents the probe workflow and constraints.| |**CSS blur selectors**
    `src-tauri/inject/messenger.css`|Updates blur rules to target private identity markers plus profile-linked header, avatar, and receipt elements in the main Messenger pane.| **Estimated code review effort:** 4 (Complex) | ~45 minutes **Possibly related issues** - [kristofferR/Carrier#23](https://github.com/kristofferR/Carrier/issues/23): Matches the same hide-names expansion to additional Messenger identity surfaces in the stylesheet. **Possibly related PRs** - [[kristofferR/Carrier#11](https://github.com/kristofferR/Carrier/issues/11)](https://github.com/kristofferR/Carrier/pull/11): Directly changes the same `execute-js` responder path in `src-tauri/inject/mcp-bridge.js`, which this PR extends with a sentinel probe. - [[kristofferR/Carrier#22](https://github.com/kristofferR/Carrier/issues/22)](https://github.com/kristofferR/Carrier/pull/22): Closely related hide-names work in the same Messenger inject assets, with overlapping privacy and selector changes.
    🚥 Pre-merge checks | ✅ 5
    ✅ Passed checks (5 passed) | Check name | Status | Explanation | | :------------------------: | :------- | :--------------------------------------------------------------------------------------------------------- | | Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. | | Title check | ✅ Passed | The title clearly matches the main change: expanding Hide Names privacy coverage in Messenger. | | Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. | | Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. | | Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
    ✨ Finishing Touches
    📝 Generate docstrings - [ ] Create stacked PR - [ ] Commit on current branch
    🧪 Generate unit tests (beta) - [ ] Create PR with unit tests - [ ] Commit unit tests in branch `codex/issue-23-hide-thread-privacy`

    Comment @coderabbitai help to get the list of available commands.

     
  • Anonymous

    Anonymous - 2026-07-01

    Originally posted by: kristofferR

    @coderabbitai review

     
  • Anonymous

    Anonymous - 2026-07-01

    Originally posted by: coderabbitai[bot]

    ✅ Action performed Review finished. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
     
  • Anonymous

    Anonymous - 2026-07-01

    Originally posted by: kristofferR

    @coderabbitai review

     
  • Anonymous

    Anonymous - 2026-07-01

    Originally posted by: coderabbitai[bot]

    ✅ Action performed Review finished. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
     
  • Anonymous

    Anonymous - 2026-07-01

    Ticket changed by: kristofferR

    • status: open --> closed
     

Log in to post a comment.