Menu β–Ύ β–΄

#387 feat(notifications): optionally stop notifying for group chats

closed
nobody
None
2026-11-07
2026-11-07
Anonymous
No

Originally created by: kristofferR

Busy group chats can drown out direct messages, and there was no way to keep them on the unread badge without being notified.

A new Group Chat Notifications setting (Settings β†’ Notifications, on by default) lets group-chat messages count on the badge without raising a notification.

When it is off, group chats are held back at exactly the points where muted chats already are, and recorded as suppressed, so turning it back on never swallows a later identical message:

  • page-notification delivery, row/page pairing, capacity eviction, the immediate row path, and the fallback timer before and after avatar conversion;
  • the scan's aggregate unread-count attribution, so a group's unread increase is never blamed on an older direct message;
  • the page path's identity wait, which stays on while either the muted or the group filter is active.

A conversation's kind comes from Messenger's local database (LSMessagingThreadTypeUtil) via a small cache that row scans prefetch; the fallback timer and page path wait for it before deciding. An unknown kind is delivered. With the setting on, nothing changes.

Part of [#368]; mark-as-read and react actions are not included.

Manual check still needed: with the setting off, a group message updates the badge without a notification while a direct message still notifies; turn it back on and confirm the next group message notifies.

Ref [#368]

CodeRabbit reviews this change in the combined PR [#394].

Related

Tickets: #368
Tickets: #394

Discussion

  • Anonymous

    Anonymous - 2026-11-07

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review Summary: βœ… Completed This comment shows the latest Codex review activity on this pull request. | Review | Status | Commit | Review trigger | | --- | --- | --- | --- | | πŸ“ **Code Review** | βœ… **Completed** <relative-time datetime="2026-11-07T17:30:32.367577Z">2026-11-07T17:30:32.367577Z</relative-time> | `c9ab79f` | Manual request |
    ℹ️ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review" or "@codex security review". Codex reacts with πŸ‘€ while any review is running, comments if it has suggestions, and reacts with πŸ‘ once all reviews finish with no findings.
     
  • Anonymous

    Anonymous - 2026-11-07

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review: Didn't find any major issues. Hooray!

    Reviewed commit: c9ab79ff21

    ℹ️ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with πŸ‘. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
     
  • Anonymous

    Anonymous - 2026-11-07

    Originally posted by: kristofferR

    ⏸️ crq will not request further automated reviews for this pull request.

    Reason: CodeRabbit reviews these changes once, in combined PR [#394]

    Resume with crq unhold kristofferr/carrier 387.

     

    Related

    Tickets: #394

  • Anonymous

    Anonymous - 2026-11-07

    Ticket changed by: kristofferR

    • status: open --> closed
     
  • Anonymous

    Anonymous - 2026-11-07

    Originally posted by: kristofferR

    βœ… The administrative hold has been retired because this pull request merged. crq will not request further automated reviews.

     

Log in to post a comment.