Menu ▾ ▴

#383 feat(badge): choose how muted conversations count

closed
nobody
None
2026-11-07
2026-11-07
Anonymous
No

Originally created by: kristofferR

Muted conversations were either left out of both the unread badge and notifications, or counted in both. There was no way to see muted chats on the badge without being notified about them, a "badge-only quiet mode" other Messenger clients offer.

Settings → Notifications replaces the "Ignore muted conversations" switch with a Muted conversations choice:

  • Leave out — no badge, no notification (the old switch on; the default)
  • Badge only — counted on the unread badge, never notified (new)
  • Badge and notify — treated like any other chat (the old switch off)

The new muted_conversations setting is optional: until a policy is picked, the legacy switch still decides, so existing installs keep their behavior. Unknown values load as unset. The badge now asks "are muted chats left off the badge?" and notifications ask "do muted chats stay silent?", which is what makes Badge only possible.

Part of [#259]; the dot badge is still to come.

Ref [#259]

CodeRabbit reviews this change in the combined PR [#394].

Related

Tickets: #259
Tickets: #394

Discussion

  • Anonymous

    Anonymous - 2026-11-07

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review Summary: ✅ Completed This comment shows the latest Codex review activity on this pull request. | Review | Status | Commit | Review trigger | | --- | --- | --- | --- | | 📝 **Code Review** | ✅ **Completed** <relative-time datetime="2026-11-07T16:52:16.240269Z">2026-11-07T16:52:16.240269Z</relative-time> | `a7ff16c` | Manual request |
    ℹ️ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review" or "@codex security review". Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
     
  • Anonymous

    Anonymous - 2026-11-07

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review: Didn't find any major issues. More of your lovely PRs please.

    Reviewed commit: a7ff16cc02

    ℹ️ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
     
  • Anonymous

    Anonymous - 2026-11-07

    Originally posted by: kristofferR

    ⏸️ crq will not request further automated reviews for this pull request.

    Reason: CodeRabbit reviews these changes once, in combined PR [#394]

    Resume with crq unhold kristofferr/carrier 383.

     

    Related

    Tickets: #394

  • Anonymous

    Anonymous - 2026-11-07

    Originally posted by: kristofferR

    [!NOTE]
    🤖 Claude Opus 5.5 responding on behalf of Kristoffer

    Tested on Linux with a muted 1:1 chat and messages from the other side:

    • Leave out: no notification, and the chat isn't counted on the unread badge.
    • Badge only: counted on the badge (2 → 3 unread), no notification.
    • Badge and notify: counted on the badge, and exactly one notification.

    Rebased onto main, keeping the new Privacy tab.

     
  • Anonymous

    Anonymous - 2026-11-07

    Ticket changed by: kristofferR

    • status: open --> closed
     
  • Anonymous

    Anonymous - 2026-11-07

    Originally posted by: kristofferR

    ✅ The administrative hold has been retired because this pull request merged. crq will not request further automated reviews.

     

Log in to post a comment.