Fix Linux Wayland WebKit DMABUF rendering
Facebook Messenger on your desktop, without the Facebook clutter
Brought to you by:
kristoffer-r
Originally created by: kristofferR
Carrier's Linux build uses WebKitGTK, which is still exposed to DMABUF renderer failures that can produce blank, black, or garbled webviews on affected Wayland systems.
Ref [#31]
Originally posted by: kristofferR
@coderabbitai review
Originally posted by: coderabbitai[bot]
β Action performed
Review finished. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.Originally posted by: coderabbitai[bot]
No actionable comments were generated in the recent review. π
βΉοΈ Recent review info
βοΈ Run configuration
**Configuration used**: Path: .coderabbit.yaml **Review profile**: ASSERTIVE **Plan**: Pro **Run ID**: `9e4a20f5-e79b-4413-857b-71f0e62a5032`π₯ Commits
Reviewing files that changed from the base of the PR and between [d7bd1b] and bfafff8f3bd0058075b553d4acbd473deefdc2aa.π Files selected for processing (1)
* `src-tauri/src/lib.rs`π Walkthrough
## Walkthrough Adds Linux-only logic in `src-tauri/src/lib.rs` to disable the WebKit DMABUF renderer when running under Wayland without a user override. Introduces a predicate function and a configuration function invoked during app startup, plus a unit test covering the predicate's behavior. ### Changes **WebKit DMABUF renderer fix** |Layer / File(s)|Summary| |---|---| |**Predicate, configuration, and startup wiring**`src-tauri/src/lib.rs`|Adds `should_disable_webkit_dmabuf_renderer` predicate and `configure_linux_webkit_renderer` function that reads `WAYLAND_DISPLAY`/`WEBKIT_DISABLE_DMABUF_RENDERER` env vars and sets the override; called in `run()` before early settings load and Tauri builder construction.| |**Predicate unit test**
`src-tauri/src/lib.rs`|Adds a unit test verifying the predicate's truth table across Wayland presence and override combinations.| **Estimated code review effort:** 1 (Trivial) | ~5 minutes **Possibly related issues** - [kristofferR/Carrier#31](https://github.com/kristofferR/Carrier/issues/31): Implements the same Linux/Wayland `WEBKIT_DISABLE_DMABUF_RENDERER` startup workaround described in this issue.
π₯ Pre-merge checks | β 5
β Passed checks (5 passed)
| Check name | Status | Explanation | | :------------------------: | :------- | :--------------------------------------------------------------------------------------------------------- | | Description Check | β Passed | Check skipped - CodeRabbitβs high-level summary is enabled. | | Title check | β Passed | The title clearly summarizes the main Linux Wayland WebKit DMABUF rendering fix. | | Docstring Coverage | β Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. | | Linked Issues check | β Passed | Check skipped because no linked issues were found for this pull request. | | Out of Scope Changes check | β Passed | Check skipped because no linked issues were found for this pull request. |β¨ Finishing Touches
π Generate docstrings
- [ ] Create stacked PR - [ ] Commit on current branchπ§ͺ Generate unit tests (beta)
- [ ] Create PR with unit tests - [ ] Commit unit tests in branch `codex/fix-31-wayland-dmabuf`Comment
@coderabbitai helpto get the list of available commands.Ticket changed by: kristofferR