Menu โ–พ โ–ด

#377 fix(security): stop granting IPC to Facebook's user-content hosts

closed
nobody
None
2026-11-07
2026-11-07
Anonymous
No

Originally created by: kristofferR

Carrier's remote capability granted core:event:allow-emit (and the badge, notification-permission and opener plugins) to fbcdn.net and fbsbx.com as well as facebook.com and messenger.com. Those two hosts serve user-uploaded photos, files and sandboxed frames, so any script on them could emit any carrier:* event Carrier listens for.

Nothing legitimate needs IPC there: Carrier already keeps its privileged bridges, Messenger features and panel out of top-level fbcdn/fbsbx documents, and the frame audio script never reports from subframes. This limits the remote capability to facebook.com and messenger.com, adds a test pinning that, and corrects the IPC-model notes in AGENTS.md (including the platform caveat that Linux attributes subframe IPC to the top-level page, and stale examples). The dev-only MCP capability is unchanged.

First step of [#354]; moving file-touching events to typed, per-origin commands is the follow-up.

Ref [#354]

CodeRabbit reviews this change in the combined PR [#394].

Related

Tickets: #349
Tickets: #354
Tickets: #394

Discussion

  • Anonymous

    Anonymous - 2026-11-07

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review Summary: โœ… Completed This comment shows the latest Codex review activity on this pull request. | Review | Status | Commit | Review trigger | | --- | --- | --- | --- | | ๐Ÿ“ **Code Review** | โœ… **Completed** <relative-time datetime="2026-11-07T16:04:32.538052Z">2026-11-07T16:04:32.538052Z</relative-time> | `be2e70c` | Manual request |
    โ„น๏ธ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review" or "@codex security review". Codex reacts with ๐Ÿ‘€ while any review is running, comments if it has suggestions, and reacts with ๐Ÿ‘ once all reviews finish with no findings.
     
  • Anonymous

    Anonymous - 2026-11-07

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review: Didn't find any major issues. ๐Ÿš€

    Reviewed commit: be2e70c5d0

    โ„น๏ธ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with ๐Ÿ‘. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
     
  • Anonymous

    Anonymous - 2026-11-07

    Originally posted by: kristofferR

    @coderabbitai review

     
  • Anonymous

    Anonymous - 2026-11-07

    Originally posted by: coderabbitai[bot]

    Action not completed

    Review rate limited. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
     
  • Anonymous

    Anonymous - 2026-11-07

    Originally posted by: coderabbitai[bot]

    [!WARNING]

    Review limit reached

    You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

    Next included review available in 58 minutes.

    Check out review usage here.


    View limit details



    Limit details: Youโ€™ve used the included review currently available.

    Learn how review limits work.

    Review configuration:


    <picture></picture> Run configuration






    <picture></picture> Commits



    Reviewing files that changed from the base of the PR and between [0c0ca9] and be2e70c5d0d27f7af2d6fa5f7a5dbf4914506f8c.




    <picture></picture> Files selected for processing: 3



    • AGENTS.md
    • inject/src/messenger/lib/injected-assets.test.ts
    • src-tauri/capabilities/default.json





    • [ ] Autofix ยท Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

    Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

    Share

    - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
     

    Related

    Commit: [0c0ca9]

  • Anonymous

    Anonymous - 2026-11-07

    Originally posted by: kristofferR

    โธ๏ธ crq will not request further automated reviews for this pull request.

    Reason: CodeRabbit reviews these changes once, in combined PR [#394]

    Resume with crq unhold kristofferr/carrier 377.

     

    Related

    Tickets: #394

  • Anonymous

    Anonymous - 2026-11-07

    Ticket changed by: kristofferR

    • status: open --> closed
     
  • Anonymous

    Anonymous - 2026-11-07

    Originally posted by: kristofferR

    โœ… The administrative hold has been retired because this pull request merged. crq will not request further automated reviews.

     

Log in to post a comment.