Chatpane / Tickets / #342 fix: Messenger calls on macOS and file attachment downloads

Originally posted by: chatgpt-codex-connector[bot]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed <relative-time datetime="2026-11-05T01:23:18.097628Z">2026-11-05T01:23:18.097628Z</relative-time>	`d7c38a9`	Manual request

ℹ️ About Codex in GitHub

[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review" or "@codex security review". Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Originally posted by: coderabbitai[bot]

<picture> Explain Change → </picture>

[!WARNING]

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

<picture></picture> Run configuration

Source mode: Auto

Repository: kristofferR/Carrier

Branch: t3/solve-issues

File: .coderabbit.yaml (github.com)

Commit: d7c38a9

Layers: Repository YAML

Review profile: ASSERTIVE

Plan: Advanced

Run ID: f1d28201-e331-4ef1-9b09-560fdb485cde

<picture></picture> Commits

Reviewing files that changed from the base of the PR and between [7a9663] and d7c38a92fa6f3734ad8216b2e205a1b601a4d1cd.

<picture></picture> Files selected for processing: 3

docs/user-agent-policy.md

src-tauri/src/download.rs

src-tauri/src/user_agent.rs

Walkthrough

The changes expand eligible downloads to include selected attachments, add authenticated reporting for folder-access denials with a macOS privacy-settings action, and apply a validated Safari-based user agent to macOS Messenger windows. **Changes: Download handling** |Layer / File(s)|Summary| |:---|:---| |**Attachment download eligibility**
`AGENTS.md`, `README.md`, `src-tauri/src/download.rs`, `src-tauri/src/window.rs`, `src-tauri/src/lib.rs`|The download policy allows selected attachment extensions for eligible blob and HTTPS downloads. `data:` URLs remain limited to media. Documentation and policy logs now describe media and attachments.| |**Verified folder-access denial reporting**
`src-tauri/src/download.rs`, `src-tauri/src/window.rs`, `src-tauri/src/lib.rs`, `src-tauri/inject/messenger.js`, `inject/src/messenger/*`|Completion signatures now include a `denied` flag. The native and injected code detect folder-access denials, verify completion events, and show a warning for confirmed denials.| |**Download privacy-settings action**
`src-tauri/Cargo.toml`, `src-tauri/src/download.rs`, `src-tauri/src/lib.rs`, `src-tauri/src/window.rs`, `src-tauri/inject/panel.js`, `inject/src/panel/toast.ts`, `inject/src/types.d.ts`, `inject/src/messenger/lib/downloads.ts`, `inject/src/messenger/lib/downloads.test.ts`|The warning offers an Open Settings action on macOS and permission guidance on Windows and Linux. The action invokes an authorized native listener to open the macOS download-folder privacy settings URL.| **macOS Messenger user agent** |Layer / File(s)|Summary| |:---|:---| |**Safari-based user-agent policy**
`docs/user-agent-policy.md`, `src-tauri/src/user_agent.rs`|The resolver uses the installed Safari version for a macOS user-agent override when the version passes validation. Other platforms retain their native identity. The policy and tests describe the exception and fallback behavior.| **Estimated code review effort:** 3 (Moderate) | ~25 minutes **Change:** Bug fix ### Sequence Diagram(s) :::mermaid sequenceDiagram participant DownloadHandler participant CompletionVerifier participant AccessDeniedToast participant User participant PrivacyBridge participant TauriListener participant SettingsOpener DownloadHandler->>CompletionVerifier: Send signed completion with denied flag CompletionVerifier->>AccessDeniedToast: Show warning after verifying denied completion User->>AccessDeniedToast: Select Open Settings AccessDeniedToast->>PrivacyBridge: Call carrierOpenDownloadPrivacy PrivacyBridge->>TauriListener: Emit carrier:open-download-privacy TauriListener->>SettingsOpener: Open platform privacy URL **Possibly related issues** - Issue 334 reports that Carrier downloads fail on a Mac while Safari downloads succeed. This PR changes attachment eligibility and adds macOS folder-access denial reporting. - Issue 335 reports unavailable Messenger voice and video calls on an ARM Mac. This PR changes the macOS user agent used for Messenger.

Merge Risk: <picture></picture> Moderate · previous review 7a966

On older supported macOS versions, Messenger may accept the Safari version check while the embedded webview lacks the needed features, so calls may still fail or break. The folder-permission warning could also be missed when a folder is readable but not writable. Verify the call behavior on Big Sur or restrict the override before merging.

Pre-merge checks: ^{<picture></picture>} 3 · ^{<picture></picture>} 2

^{<picture></picture>} Failed checks: 2 warnings | Check name | Status | Explanation | Resolution | | :---------------- | :----------------------------------------------------------------------------------------------: | :-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | | Description check | ![Warning](https://storage.googleapis.com/coderabbit_public_assets/pre-merge-checks-warning.svg) | The description follows the template's Summary section with a clear problem and change description, and it covers all three changes with issue references. The "AI models used" section is missing. The … | Add the "AI models used:" line under the Summary section. Replace the placeholder with the model names and versions used to create or edit code, tests, or PR text, or write "None" if no AI helped. Optionally add the "Reasoning levels" line,… | | Docstring Coverage | ![Warning](https://storage.googleapis.com/coderabbit_public_assets/pre-merge-checks-warning.svg) | Docstring coverage is 27.78% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… | Write docstrings for the functions missing them to satisfy the coverage threshold. |

^{<picture></picture>} Passed checks: 3 passed

| Check name | Status | Explanation | | :------------------------ | :--------------------------------------------------------------------------------------------: | :-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | Title check | ![Passed](https://storage.googleapis.com/coderabbit_public_assets/pre-merge-checks-passed.svg) | The title "fix: Messenger calls on macOS and file attachment downloads" matches the two main changes in the changeset: the macOS Safari user-agent override for Messenger calls, and the expanded attach… | | Linked Issues check | ![Passed](https://storage.googleapis.com/coderabbit_public_assets/pre-merge-checks-passed.svg) | Check skipped because no linked issues were found for this pull request. | | Out of Scope Changes check | ![Passed](https://storage.googleapis.com/coderabbit_public_assets/pre-merge-checks-passed.svg) | Check skipped because no linked issues were found for this pull request. |

Full details: Title check

**Explanation** The title "fix: Messenger calls on macOS and file attachment downloads" matches the two main changes in the changeset: the macOS Safari user-agent override for Messenger calls, and the expanded attachment allowlist for downloads. It omits the third change, the Downloads-folder access-denied handling, which is a secondary but real part of the PR. The title is specific and follows a conventional commit style.

Full details: Description check

**Explanation** The description follows the template's Summary section with a clear problem and change description, and it covers all three changes with issue references. The "AI models used" section is missing. The template makes it required for contributors other than the repository owner, and the description does not state a value such as "None" or list models. The "Reasoning levels" section is optional and does not block the PR. **Resolution** Add the "AI models used:" line under the Summary section. Replace the placeholder with the model names and versions used to create or edit code, tests, or PR text, or write "None" if no AI helped. Optionally add the "Reasoning levels" line, using "Unavailable (not exposed by tool)" if the tool does not expose it.

Full details: Docstring Coverage

**Explanation** Docstring coverage is 27.78% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 18 functions across 14 files. (4 skipped: 4 unsupported.) **Resolution** Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches

Generate docstrings

- [ ] Commit to this branch - [ ] Create a new PR

Generate unit tests (beta)

- [ ] Commit to this branch - [ ] Create a new PR

[ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Commit: [7a9663]

fix: Messenger calls on macOS and file attachment downloads

Facebook Messenger on your desktop, without the Facebook clutter

Milestone

Searches

Help

#342 fix: Messenger calls on macOS and file attachment downloads

Summary by CodeRabbit

Related

Discussion

Codex Review Summary

Review limit reached

Related