Menu ▾ ▴

#324 fix: use native WebView zoom so zoomed pages fit the window

closed
nobody
None
2026-10-17
2026-10-16
Anonymous
No

Originally created by: kristofferR

Zooming in (Cmd/Ctrl + +) clipped the right and bottom edges of Messenger and could push the message input below the window. Carrier zoomed with CSS zoom on the document (a body transform on Windows), which scales Messenger's viewport-sized layout past the window instead of shrinking the viewport it lays out into.

This switches page zoom to the native WebView zoom (WKWebView pageZoom, WebKitGTK zoom level, WebView2 ZoomFactor), as proposed in [#250]:

  • Rust applies the zoom on window creation, on each Messenger page load, on settings changes, and immediately on the page's carrier:zoom event (persisting stays coalesced as before). No new command is exposed to the remote page.
  • The page no longer touches CSS; it only tracks the level and reports keyboard/menu zoom steps.
  • The CSS-zoom compensation in Hide Names and the scheduled-send composer is removed, since bounding rects are no longer scaled, along with the browser-test cases that simulated CSS zoom.

Checked on Linux: native 150% zoom reports an 800×520 layout viewport in a 1200×780 window, so Messenger reflows to fit. macOS and Windows still need a manual pass (keyboard steps, Settings zoom select, new windows, theme recreation).

Ref [#318]
Ref [#250]

Related

Tickets: #250
Tickets: #264
Tickets: #318

Discussion

  • Anonymous

    Anonymous - 2026-10-17

    Originally posted by: coderabbitai[bot]

    ⚠️ Action not completed Review rate limited. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
     
  • Anonymous

    Anonymous - 2026-10-17

    Originally posted by: coderabbitai[bot]

    [!WARNING]

    Review limit reached

    You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

    Next included review available in 58 minutes.

    Check out review usage here.


    View limit details

    Limit details: You’ve used the included review currently available.

    Learn how review limits work.

    Review configuration:


    ⚙️ Run configuration

    • Configuration used: Repository: kristofferR/Carrier/.coderabbit.yaml
    • Review profile: ASSERTIVE
    • Plan: Advanced
    • Run ID: d7eddf2f-83d3-45b2-9ca7-ba20febc3c74




    📥 Commits

    Reviewing files that changed from the base of the PR and between [975f45] and 11fa5aba9160e56af91b587c19f544daec6bf0d8.




    📒 Files selected for processing: 10

    • inject/src/messenger/features/hide-names.ts
    • inject/src/messenger/features/zoom.ts
    • inject/src/messenger/lib/media-viewer.browser.test.ts
    • inject/src/messenger/lib/media-viewer.ts
    • inject/src/messenger/lib/scheduled-composer.ts
    • inject/src/messenger/lib/scheduled-send.browser.test.ts
    • src-tauri/inject/messenger.js
    • src-tauri/src/lib.rs
    • src-tauri/src/settings.rs
    • src-tauri/src/window.rs





    • [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

    Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

    ❤️ Share
    - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

    Comment @coderabbitai help to get the list of available commands.

     

    Related

    Commit: [975f45]

  • Anonymous

    Anonymous - 2026-10-17

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review Summary

    This comment shows the latest Codex review activity on this pull request.

    Review Status Commit Review trigger
    📝 Code Review ✅ Completed <relative-time datetime="2026-10-17T01:41:21.516124Z">2026-10-17T01:41:21.516124Z</relative-time> 26d09d0 Manual request
    ℹ️ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review" or "@codex security review". Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
     
  • Anonymous

    Anonymous - 2026-10-17

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review: Didn't find any major issues. Hooray!

    Reviewed commit: af209fcccd

    ℹ️ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
     
  • Anonymous

    Anonymous - 2026-10-17

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review: Didn't find any major issues. Bravo.

    Reviewed commit: 26d09d069b

    ℹ️ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
     
  • Anonymous

    Anonymous - 2026-10-17

    Ticket changed by: kristofferR

    • status: open --> closed
     

Log in to post a comment.