Menu ▾ ▴

#278 fix: use native WebView user-agent identities

closed
nobody
None
2026-10-05
2026-09-06
Anonymous
No

Originally created by: kristofferR

Carrier hardcodes Safari 17.4 on macOS and Chrome 124 on Windows and Linux, even though Linux runs WebKit. Leave the user agent unset so each embedded engine supplies its native identity, with compatibility exceptions centralized in one policy module.

Added policy-selection/fallback tests and a platform verification matrix. Navigation, CSP, and remote-origin restrictions are unchanged.

Validation: cargo fmt, Clippy with warnings denied, 257 Rust tests, and bun run check (485 tests, lint, typechecking, bundle regeneration) pass. Local CodeRabbit preflight findings were checked: clarified the probe date's timezone; Settings already uses a separate builder.

A WebKitGTK 2.52.6 probe reached the login form with both native and previous user agents. Authenticated functionality and macOS/Windows/oldest-supported-version testing remain pending, documented in docs/user-agent-policy.md; this is not full compatibility qualification.

Ref [#258]

Related

Tickets: #258
Tickets: #264

Discussion

  • Anonymous

    Anonymous - 2026-09-06

    Originally posted by: kristofferR

    @coderabbitai review

     
  • Anonymous

    Anonymous - 2026-09-06

    Originally posted by: kristofferR

    @codex review for consequential defects introduced by this PR; do not expand its original scope with unrelated refactors, features, or speculative hardening

     
  • Anonymous

    Anonymous - 2026-09-06

    Originally posted by: coderabbitai[bot]

    ⚠️ Action not completed Review rate limited. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
     
  • Anonymous

    Anonymous - 2026-09-06

    Originally posted by: coderabbitai[bot]

    [!WARNING]

    Review limit reached

    Next included review available in 43 minutes.

    Check out review usage here.


    View limit details

    Limit details: You’ve used the included review currently available.

    You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

    Learn how review limits work.

    Review configuration:


    ⚙️ Run configuration

    Configuration used: Path: .coderabbit.yaml

    Review profile: ASSERTIVE

    Plan: Team

    Run ID: 70312937-5417-4b56-8e57-3756132d7768


    📥 Commits

    Reviewing files that changed from the base of the PR and between [2b12db] and eb8269eedf1c83061f183852b7350cbb867f11e8.


    📒 Files selected for processing (4)

    • docs/user-agent-policy.md
    • src-tauri/src/lib.rs
    • src-tauri/src/user_agent.rs
    • src-tauri/src/window.rs

    Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

    ❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

    Comment @coderabbitai help to get the list of available commands.

     

    Related

    Commit: [2b12db]

  • Anonymous

    Anonymous - 2026-09-06

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review Summary

    This comment shows the latest Codex review activity on this pull request.

    Review Status Commit Review trigger
    📝 Code Review ✅ Completed <relative-time datetime="2026-09-06T23:52:32.007781Z">2026-09-06T23:52:32.007781Z</relative-time> eb8269e Manual request
    ℹ️ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review" or "@codex security review". Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
     
  • Anonymous

    Anonymous - 2026-09-06

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review: Didn't find any major issues. Delightful!

    Reviewed commit: eb8269eedf

    ℹ️ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
     
  • Anonymous

    Anonymous - 2026-09-06

    Ticket changed by: kristofferR

    • status: open --> closed
     

Log in to post a comment.