Menu β–Ύ β–΄

#277 fix(macos): restore standard application and Window menus

closed
nobody
None
2026-10-05
2026-09-06
Anonymous
No

Originally created by: kristofferR

Carrier's macOS application menu omits Services, Hide Others, and Show All, and its Window submenu is not registered with AppKit.

Add the standard application items and use Tauri's reserved Window submenu ID, which registers the installed menu with AppKit so macOS can populate its supported window controls and live window list. Add the native Bring All to Front command explicitly, since macOS 27 does not insert it automatically. Existing custom Zoom, Close, and multi-window commands remain in place, as does menu-bar-only activation behavior. Fullscreen changes remain scoped to [#256].

Validation: clean local CodeRabbit preflight; macOS cargo check; cargo fmt, Clippy, and 255 Rust tests; Biome, TypeScript, 485 Bun tests, and injection bundle build. Live testing on macOS 27 in an isolated debug app verified Services population, Hide Others/Show All, Fill/Center, Move & Resize and size restoration, Zoom, multiple windows and keyboard cycling, Close, Minimize, Bring All to Front, Settings, and menu-bar-only toggling. Oldest-supported macOS remains untested. The follow-up local preflight was skipped by crq during a shared account quota block.

Ref [#261]

Summary by CodeRabbit

  • New Features
  • Added a Services submenu to the macOS application menu.
  • Added Hide Others and Show All actions.
  • Expanded the macOS Window menu with Bring All to Front and a live list of open windows.

Related

Tickets: #256
Tickets: #261
Tickets: #264

Discussion

  • Anonymous

    Anonymous - 2026-09-06

    Originally posted by: kristofferR

    @coderabbitai review

     
  • Anonymous

    Anonymous - 2026-09-06

    Originally posted by: kristofferR

    @codex review for consequential defects introduced by this PR; do not expand its original scope with unrelated refactors, features, or speculative hardening

     
  • Anonymous

    Anonymous - 2026-09-06

    Originally posted by: coderabbitai[bot]

    βœ… Action performed Review finished. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
     
  • Anonymous

    Anonymous - 2026-09-06

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review Summary

    This comment shows the latest Codex review activity on this pull request.

    Review Status Commit Review trigger
    πŸ“ Code Review βœ… Completed <relative-time datetime="2026-09-06T23:59:17.996332Z">2026-09-06T23:59:17.996332Z</relative-time> 24fd535 Manual request
    ℹ️ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review" or "@codex security review". Codex reacts with πŸ‘€ while any review is running, comments if it has suggestions, and reacts with πŸ‘ once all reviews finish with no findings.
     
  • Anonymous

    Anonymous - 2026-09-06

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review: Didn't find any major issues. More of your lovely PRs please.

    Reviewed commit: b5ebbbbe9d

    ℹ️ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with πŸ‘. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
     
  • Anonymous

    Anonymous - 2026-09-06

    Originally posted by: coderabbitai[bot]

    Review Change Stack

    No actionable comments were generated in the recent review. πŸŽ‰

    ℹ️ Recent review info
    βš™οΈ Run configuration **Configuration used**: Path: .coderabbit.yaml **Review profile**: ASSERTIVE **Plan**: Team **Run ID**: `a8a7da7d-0233-48e3-b889-7afcd57cd1ee`
    πŸ“₯ Commits Reviewing files that changed from the base of the PR and between [b5ebbb] and 24fd53582573835c812cd48fc1eec7eb0e61bc9c.
    πŸ“’ Files selected for processing (1) * `src-tauri/src/menu.rs`
    **Included review availability:** Your plan provides up to 1 included review per hour; 0 remain after this review.

    πŸ“ Walkthrough ## Walkthrough The macOS application menu adds Services and standard visibility actions. The Window submenu uses Tauri’s standard submenu ID and adds Bring All to Front. ### Changes **macOS menu behavior** |Layer / File(s)|Summary| |---|---| |**Application menu actions**
    `src-tauri/src/menu.rs`|The application menu adds a Services submenu and standard Hide Others and Show All actions.| |**Window submenu registration**
    `src-tauri/src/menu.rs`|The Window submenu uses `WINDOW_SUBMENU_ID` and adds Bring All to Front.| **Estimated code review effort:** 1 (Trivial) | ~5 minutes **Merge Risk:** _🟑 Moderate_ · up to `24fd5` The macOS menu additions may not be present in release builds if the applicable feature gate excludes them, preventing users from receiving the intended standard menu behavior. Resolve or explicitly accept this release-build risk before merging.
    πŸš₯ Pre-merge checks | βœ… 5
    βœ… Passed checks (5 passed) | Check name | Status | Explanation | | :------------------------: | :------- | :---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | Description Check | βœ… Passed | Check skipped - CodeRabbit’s high-level summary is enabled. | | Title check | βœ… Passed | The title clearly and concisely describes the main change: restoring standard macOS application and Window menus. | | Docstring Coverage | βœ… Passed | Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. | | Linked Issues check | βœ… Passed | Check skipped because no linked issues were found for this pull request. | | Out of Scope Changes check | βœ… Passed | Check skipped because no linked issues were found for this pull request. |
    ✨ Finishing Touches
    πŸ“ Generate docstrings - [ ] Create stacked PR - [ ] Commit on current branch
    πŸ§ͺ Generate unit tests (beta) - [ ] Create PR with unit tests - [ ] Commit unit tests in branch `fix/261-macos-menus`

    Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

    ❀️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

    Comment @coderabbitai help to get the list of available commands.

     
  • Anonymous

    Anonymous - 2026-09-06

    Originally posted by: kristofferR

    @codex review for consequential defects introduced by this PR; do not expand its original scope with unrelated refactors, features, or speculative hardening

     
  • Anonymous

    Anonymous - 2026-09-06

    Originally posted by: chatgpt-codex-connector[bot]

    Codex Review: Didn't find any major issues. πŸ‘

    Reviewed commit: 24fd535825

    ℹ️ About Codex in GitHub
    [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with πŸ‘. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
     
  • Anonymous

    Anonymous - 2026-09-07

    Originally posted by: kristofferR

    @coderabbitai review

     
  • Anonymous

    Anonymous - 2026-09-07

    Originally posted by: coderabbitai[bot]

    βœ… Action performed Review finished. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
     
  • Anonymous

    Anonymous - 2026-09-07

    Ticket changed by: kristofferR

    • status: open --> closed
     

Log in to post a comment.