Chatpane / Tickets / #229 feat: ask where to save downloads

Originally posted by: coderabbitai[bot]

📝 Walkthrough

## Walkthrough The change adds a persisted download behavior setting with automatic and prompted modes. Native save dialogs validate and reserve paths. Download flows use the selected path, enforce safe destinations, and suppress cancellation toasts. ### Changes **Download behavior configuration** |Layer / File(s)|Summary| |---|---| |**Settings and bridge contract**
`dist/settings.html`, `inject/src/types.d.ts`, `src-tauri/src/settings.rs`, `inject/src/messenger/lib/injected-assets.test.ts`|The General tab exposes `downloads` and `ask` options. Settings validation and defaults support both values. The injected bridge declares the chooser call.| |**Native picker protocol**
`src-tauri/Cargo.toml`, `src-tauri/src/download.rs`, `src-tauri/src/lib.rs`, `src-tauri/src/window.rs`|The dialog plugin presents save dialogs. Signed results cover presentation and completion phases. Selected paths receive validation, bounded reservations, and one-time consumption.| |**Download path enforcement**
`src-tauri/src/window.rs`|Prompted downloads use approved paths. Unprompted downloads fail in `ask` mode. Automatic downloads use unique paths in the Downloads directory.| |**Injected download flows and feedback**
`inject/src/messenger/...`, `src-tauri/inject/messenger.js`|Download and share failures use centralized handling. Cancellation errors produce no toast. Success messages reflect the selected behavior. Untrusted anchor clicks are ignored.| **Estimated code review effort:** 4 (Complex) | ~60 minutes **Merge Risk:** _🔵 Low_ · up to `ccbd6` The change adds an optional save dialog while preserving automatic downloads by default. A bounded risk remains because some rejected downloads may appear as silent cancellations, leaving users without feedback and making diagnosis harder; this should be addressed or explicitly accepted by the owner. ### Sequence Diagram(s) :::mermaid sequenceDiagram participant Page participant InjectedBridge participant TauriChooser participant SaveDialog participant DownloadWindow Page->>InjectedBridge: Start download in ask mode InjectedBridge->>TauriChooser: Request URL and filename TauriChooser->>SaveDialog: Show native save dialog SaveDialog-->>TauriChooser: Return selected path or cancellation TauriChooser-->>InjectedBridge: Return signed chooser result InjectedBridge->>DownloadWindow: Start download DownloadWindow->>TauriChooser: Consume reserved path DownloadWindow-->>InjectedBridge: Return download result InjectedBridge-->>Page: Show success or failure toast

🚥 Pre-merge checks | ✅ 4 | ❌ 1

✅ Passed checks (4 passed)

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

- [ ] Create stacked PR - [ ] Commit on current branch

🧪 Generate unit tests (beta)

- [ ] Create PR with unit tests - [ ] Commit unit tests in branch `t3code/implement-issue-219`

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

_{Comment @coderabbitai help to get the list of available commands.}

feat: ask where to save downloads

Facebook Messenger on your desktop, without the Facebook clutter

Milestone

Searches

Help

#229 feat: ask where to save downloads

Summary by CodeRabbit

Related

Discussion