cgdb-devel — Development activity -- bug reports, patches, related questions

Re: [Cgdb-devel] gdbmi_driver installation bug + highlighting the current line

[Bob R. <bob...@co...>]

On Thu, Oct 05, 2006 at 06:34:00PM +0200, Haakon Riiser wrote:
> [Bob Rossi]
> 
> >> As for my enhancement, I was wondering if you'd consider making
> >> it an option to highlight the entire current line when scrolling
> >> around in the source window.  The current behavior is to make
> >> the current line number bold, but I find it much easier to
> >> identify the current line when the highlighting extends all
> >> the way across the screen.
> 
> > This seems like a reasonable idea. I'm wondering how this is best
> > implemented though. Currently, CGDB only highlights the line number.
> > This patch would have it highlight the entire line. How would the user 
> > switch back and forth between this functionality?
> 
> I was thinking a new option.  More on this below.

OK, I can agree with this.

> > I applied your patch, and noticed that when breakpoints are set, and you
> > go over them, the current line is no longer highlighted.
> 
> Yes, don't you agree that's a feature? :-)

I agree that some people could like this. I don't like it much, and so
probably wouldn't apply it upstream as it is, but I think we can come 
up with something that we both like.

> > I don't have time to look into these but if you want to think
> > about how this option could nicely fit into CGDB from a users
> > perspective, that would be useful.
> 
> I'm not sure what you mean.  As I said above, I thought about adding
> a new highlighting group for the current line (the on that is now
> hardcoded to boldfaced text), and an option to let it extend across
> the entire line.
> 
> By the way, here's my latest version of the patch.  The only change
> is the one I described above (fixing the segfault by letting the
> normal highlighting overlay the current line highlighting).

I misunderstood the problem that you are having. Are you saying that
highlighting the line numbers with certain information isn't useful at
all times because you are scrolling to the right to the point where the
line numbers aren't even on the screen?

Just to get an idea of what you would find useful, I have a few
questions below.

Would it be useful for CGDB to highlight lines with breakpoints by
highlighting the entire line red or yellow (based on breakpoint 
enabled or disabled) instead of just the line number?

Would it be useful for CGDB to highlight the current line the user is
browsing by highlighting the entire line instead of just the line
number?

Thanks,
Bob Rossi

Re: [Cgdb-devel] gdbmi_driver installation bug + highlighting the current line

[Steve F. <st...@fo...>]

On 10/3/06, Haakon Riiser <haa...@fy...> wrote:
> As for my enhancement, I was wondering if you'd consider making
> it an option to highlight the entire current line when scrolling
> around in the source window.  The current behavior is to make the
> current line number bold, but I find it much easier to identify the
> current line when the highlighting extends all the way across the
> screen.

I had to make a similar change myself, since the font I like
(Inconsolata) doesn't have a bold version.  I just made the
attribute/color of the hilited line number configurable, but never
submitted a patch since it was just a personal hack that didn't fit
that well with the previous behavior (particularly on lines with
breakpoints).

Just a data point to consider...  I should try Haakon's patch when I
can (I'm out of town for the weekend) to see if it makes me happy.

Re: [Cgdb-devel] gdbmi_driver installation bug + highlighting the current line

[Haakon R. <haa...@fy...>]

[Bob Rossi]

>> As for my enhancement, I was wondering if you'd consider making
>> it an option to highlight the entire current line when scrolling
>> around in the source window.  The current behavior is to make
>> the current line number bold, but I find it much easier to
>> identify the current line when the highlighting extends all
>> the way across the screen.

> This seems like a reasonable idea. I'm wondering how this is best
> implemented though. Currently, CGDB only highlights the line number.
> This patch would have it highlight the entire line. How would the user 
> switch back and forth between this functionality?

I was thinking a new option.  More on this below.

> I applied your patch, and noticed that when breakpoints are set, and you
> go over them, the current line is no longer highlighted.

Yes, don't you agree that's a feature? :-)

When I first decided to change the behavior of the current line
highlighting, it was because I was scrolling the source to set
breakpoints, and found that with heavily indented code, the
boldfaced line number all the way on the left didn't help much.

When I enable a breakpoint, I appreciate immediate visual feedback,
so just allowing the normal breakpoint highlighting to work
normally seemed like a good solution to me.  The minute you're
moving away from the breakpoint, the current line is highlighted
again, so I don't see what the problem is.

> I also noticed that if I do a search, cgdb segfaults.

That was because I had carelessly changed

  if ( sources_syntax_on ) {

to

  if (!(focus && sview->cur->sel_line == line) && sources_syntax_on) {

without considering the effects of branching into the "else"
block.

Anyway, the reason for the above change was that I wanted to
disable regular syntax highlighting for the current line.  Now,
after trying it with the regular syntax highlighting enabled,
I'm not so sure that I even /want/ to disable regular syntax
highlighting.  When using the reverse bit for highlighting the
current line, the syntax highlighting overlays quite nicely.

> I don't have time to look into these but if you want to think
> about how this option could nicely fit into CGDB from a users
> perspective, that would be useful.

I'm not sure what you mean.  As I said above, I thought about adding
a new highlighting group for the current line (the on that is now
hardcoded to boldfaced text), and an option to let it extend across
the entire line.

By the way, here's my latest version of the patch.  The only change
is the one I described above (fixing the segfault by letting the
normal highlighting overlay the current line highlighting).


--- cgdb-0.6.3/cgdb/src/sources.c.orig	2006-06-03 20:09:06.000000000 +0200
+++ cgdb-0.6.3/cgdb/src/sources.c	2006-10-05 18:04:40.829514437 +0200
@@ -675,17 +675,17 @@
             /* Ordinary lines */
             else{
                 if ( focus && sview->cur->sel_line == line )
-                    wattron(sview->win, A_BOLD);
-                    
+                {
+		    if (hl_groups_get_attr (hl_groups_instance, HLG_CURRENT_LINE, &attr) == -1)
+		        return -1;
+                    wattron(sview->win, attr);
+                }
                 wprintw(sview->win, fmt, line+1);
-                
-                if ( focus && sview->cur->sel_line == line )
-                    wattroff(sview->win, A_BOLD);
 
-                if (focus)
+                if (focus && sview->cur->sel_line != line)
                     wattron(sview->win, A_BOLD);
                 waddch(sview->win, VERT_LINE);
-                if (focus)
+                if (focus && sview->cur->sel_line != line)
                     wattroff(sview->win, A_BOLD);
                 waddch(sview->win, ' ');
                 
@@ -714,6 +714,9 @@
                                    width-lwidth-2, sview->cur->sel_col);
                     }
                 }
+                
+                if (focus && sview->cur->sel_line == line)
+                    wattroff(sview->win, attr);
             }
         } else {
             wprintw(sview->win, "%s\n", sview->cur->buf.tlines[line]);
--- cgdb-0.6.3/cgdb/src/highlight_groups.c.orig	2006-06-03 20:09:06.000000000 +0200
+++ cgdb-0.6.3/cgdb/src/highlight_groups.c	2006-10-05 17:57:10.172971689 +0200
@@ -93,6 +93,7 @@
   {HLG_ENABLED_BREAKPOINT, A_BOLD, A_BOLD, COLOR_RED, COLOR_BLACK},
   {HLG_DISABLED_BREAKPOINT, A_BOLD, A_BOLD, COLOR_YELLOW, COLOR_BLACK},
   {HLG_LOGO, A_BOLD, A_BOLD, COLOR_BLUE, COLOR_BLACK},
+  {HLG_CURRENT_LINE, A_NORMAL, A_NORMAL, COLOR_BLACK, COLOR_WHITE},
   {HLG_LAST, A_NORMAL, A_NORMAL, -1, -1}
 };
 
@@ -115,6 +116,7 @@
   {HLG_ENABLED_BREAKPOINT, A_BOLD, A_BOLD, COLOR_RED, -1},
   {HLG_DISABLED_BREAKPOINT, A_BOLD, A_BOLD, COLOR_YELLOW, -1},
   {HLG_LOGO, A_BOLD, A_BOLD, COLOR_BLUE, -1},
+  {HLG_CURRENT_LINE, A_REVERSE, A_REVERSE, -1, -1},
   {HLG_LAST, A_NORMAL, A_NORMAL, -1, -1}
 };
 
@@ -140,6 +142,7 @@
   {HLG_ENABLED_BREAKPOINT, "Breakpoint"},
   {HLG_DISABLED_BREAKPOINT, "DisabledBreakpoint"},
   {HLG_LOGO, "Logo"},
+  {HLG_CURRENT_LINE, "CurrentLine"},
   {HLG_LAST, "NULL"}
 };
 
--- cgdb-0.6.3/cgdb/include/highlight_groups.h.orig	2006-06-03 20:09:05.000000000 +0200
+++ cgdb-0.6.3/cgdb/include/highlight_groups.h	2006-10-05 17:57:10.173971501 +0200
@@ -41,6 +41,7 @@
   HLG_ENABLED_BREAKPOINT,
   HLG_DISABLED_BREAKPOINT,
   HLG_LOGO,
+  HLG_CURRENT_LINE,
 
   HLG_LAST
 };

-- 
 Haakon

Re: [Cgdb-devel] [patch, 3rd try] -d parameter fix and enhancement

[Bob R. <bob...@co...>]

On Wed, Aug 02, 2006 at 07:43:13PM +0200, Horst Schirmeier wrote:
> *sigh* my last try, fixing a SIGSEGV when **argv is NULL when comparing
> to "--"... Sorry for the noise.

Sorry for the long delay. I've committed the attached patch.

Thanks!
Bob Rossi

Re: [Cgdb-devel] gdbmi_driver installation bug + highlighting the current line

[Bob R. <bob...@co...>]

On Tue, Oct 03, 2006 at 12:06:42PM +0200, Haakon Riiser wrote:
> First of all, I'd like to thank you guys for making CGDB: Finally
> I have a good debugger with a source view and syntax highlighting
> without a bloated and buggy GUI interface! :-)

Thanks.

> Moving onward, I have one small bug report and a suggested
> enhancement (patch included).
> 
> 
> First the bug:  When doing 'make install DESTDIR=/foo', the
> installer also creates the directory /foo.. and copies
> gdbmi_driver into /foo../progs/.  Looking at the makefiles in
> lib/gdbmi/src/, I see that the problem comes from

This should be fixed in SVN now. Thanks for the report.

> As for my enhancement, I was wondering if you'd consider making
> it an option to highlight the entire current line when scrolling
> around in the source window.  The current behavior is to make the
> current line number bold, but I find it much easier to identify the
> current line when the highlighting extends all the way across the
> screen.
> 
> I've included a patch below that implements this feature.  Currently,
> it just replaces the old behavior, since that's all I need for my own
> personal use.  If you'd like to push this upstream, but not in its
> current state, let me know -- I'll gladly make the required changes.

This seems like a reasonable idea. I'm wondering how this is best
implemented though. Currently, CGDB only highlights the line number.
This patch would have it highlight the entire line. How would the user 
switch back and forth between this functionality?

I applied your patch, and noticed that when breakpoints are set, and you
go over them, the current line is no longer highlighted. I also noticed
that if I do a search, cgdb segfaults. I don't have time to look into
these but if you want to think about how this option could nicely fit
into CGDB from a users perspective, that would be useful.

Mike, any opinions?

Thanks,
Bob Rossi

[Cgdb-devel] gdbmi_driver installation bug + highlighting the current line

[Haakon R. <haa...@fy...>]

First of all, I'd like to thank you guys for making CGDB: Finally
I have a good debugger with a source view and syntax highlighting
without a bloated and buggy GUI interface! :-)

Moving onward, I have one small bug report and a suggested
enhancement (patch included).


First the bug:  When doing 'make install DESTDIR=/foo', the
installer also creates the directory /foo.. and copies
gdbmi_driver into /foo../progs/.  Looking at the makefiles in
lib/gdbmi/src/, I see that the problem comes from

  noinst_bindir = $(top_builddir)/progs

$(top_builddir) is '..', and appended to $(DESTDIR), this
gives the described result.  I haven't included a fix since
I don't know if gdbmi_driver should be installed in the bin
directory along with cgdb.


As for my enhancement, I was wondering if you'd consider making
it an option to highlight the entire current line when scrolling
around in the source window.  The current behavior is to make the
current line number bold, but I find it much easier to identify the
current line when the highlighting extends all the way across the
screen.

I've included a patch below that implements this feature.  Currently,
it just replaces the old behavior, since that's all I need for my own
personal use.  If you'd like to push this upstream, but not in its
current state, let me know -- I'll gladly make the required changes.


--- cgdb-0.6.3/cgdb/src/highlight_groups.c.orig	2006-06-03 20:09:06.000000000 +0200
+++ cgdb-0.6.3/cgdb/src/highlight_groups.c	2006-10-03 09:28:58.000000000 +0200
@@ -93,6 +93,7 @@
   {HLG_ENABLED_BREAKPOINT, A_BOLD, A_BOLD, COLOR_RED, COLOR_BLACK},
   {HLG_DISABLED_BREAKPOINT, A_BOLD, A_BOLD, COLOR_YELLOW, COLOR_BLACK},
   {HLG_LOGO, A_BOLD, A_BOLD, COLOR_BLUE, COLOR_BLACK},
+  {HLG_CURRENT_LINE, A_NORMAL, A_NORMAL, COLOR_BLACK, COLOR_WHITE},
   {HLG_LAST, A_NORMAL, A_NORMAL, -1, -1}
 };
 
@@ -115,6 +116,7 @@
   {HLG_ENABLED_BREAKPOINT, A_BOLD, A_BOLD, COLOR_RED, -1},
   {HLG_DISABLED_BREAKPOINT, A_BOLD, A_BOLD, COLOR_YELLOW, -1},
   {HLG_LOGO, A_BOLD, A_BOLD, COLOR_BLUE, -1},
+  {HLG_CURRENT_LINE, A_REVERSE, A_REVERSE, -1, -1},
   {HLG_LAST, A_NORMAL, A_NORMAL, -1, -1}
 };
 
@@ -140,6 +142,7 @@
   {HLG_ENABLED_BREAKPOINT, "Breakpoint"},
   {HLG_DISABLED_BREAKPOINT, "DisabledBreakpoint"},
   {HLG_LOGO, "Logo"},
+  {HLG_CURRENT_LINE, "CurrentLine"},
   {HLG_LAST, "NULL"}
 };
 
--- cgdb-0.6.3/cgdb/src/sources.c.orig	2006-06-03 20:09:06.000000000 +0200
+++ cgdb-0.6.3/cgdb/src/sources.c	2006-10-03 09:24:47.000000000 +0200
@@ -675,22 +675,22 @@
             /* Ordinary lines */
             else{
                 if ( focus && sview->cur->sel_line == line )
-                    wattron(sview->win, A_BOLD);
-                    
+                {
+		    if (hl_groups_get_attr (hl_groups_instance, HLG_CURRENT_LINE, &attr) == -1)
+		        return -1;
+                    wattron(sview->win, attr);
+                }
                 wprintw(sview->win, fmt, line+1);
-                
-                if ( focus && sview->cur->sel_line == line )
-                    wattroff(sview->win, A_BOLD);
 
-                if (focus)
+                if (focus && sview->cur->sel_line != line)
                     wattron(sview->win, A_BOLD);
                 waddch(sview->win, VERT_LINE);
-                if (focus)
+                if (focus && sview->cur->sel_line != line)
                     wattroff(sview->win, A_BOLD);
                 waddch(sview->win, ' ');
                 
                 /* I know this is rediculous, it needs to be reimplemented */
-                if ( sources_syntax_on ) {
+                if (!(focus && sview->cur->sel_line == line) && sources_syntax_on) {
                     /* No special line information */
                     if (line == sview->cur->sel_line && 
                             sview->cur->buf.cur_line != NULL) {
@@ -714,6 +714,9 @@
                                    width-lwidth-2, sview->cur->sel_col);
                     }
                 }
+                
+                if (focus && sview->cur->sel_line == line)
+                    wattroff(sview->win, attr);
             }
         } else {
             wprintw(sview->win, "%s\n", sview->cur->buf.tlines[line]);
--- cgdb-0.6.3/cgdb/include/highlight_groups.h.orig	2006-06-03 20:09:05.000000000 +0200
+++ cgdb-0.6.3/cgdb/include/highlight_groups.h	2006-10-03 09:17:10.000000000 +0200
@@ -41,6 +41,7 @@
   HLG_ENABLED_BREAKPOINT,
   HLG_DISABLED_BREAKPOINT,
   HLG_LOGO,
+  HLG_CURRENT_LINE,
 
   HLG_LAST
 };

-- 
 Haakon

Re: [Cgdb-devel] [patch, 3rd try] -d parameter fix and enhancement

[Mike M. <mi...@su...>]

>From GDB's man page:

-d directory
        Add directory to the path to search for source files.

Mike

On 8/3/06, Bob Rossi <bob...@co...> wrote:
> On Wed, Aug 02, 2006 at 07:43:13PM +0200, Horst Schirmeier wrote:
> > *sigh* my last try, fixing a SIGSEGV when **argv is NULL when comparing
> > to "--"... Sorry for the noise.
>
> OK, I'll hopefully get a chance to look at this soon. I like the idea.
>
> Are you sure that GDB takes the -d option?
>
> Thanks,
> Bob Rossi
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys -- and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Cgdb-devel mailing list
> Cgd...@li...
> https://lists.sourceforge.net/lists/listinfo/cgdb-devel
>

Re: [Cgdb-devel] [patch, 3rd try] -d parameter fix and enhancement

[Bob R. <bob...@co...>]

On Wed, Aug 02, 2006 at 07:43:13PM +0200, Horst Schirmeier wrote:
> *sigh* my last try, fixing a SIGSEGV when **argv is NULL when comparing
> to "--"... Sorry for the noise.

OK, I'll hopefully get a chance to look at this soon. I like the idea.

Are you sure that GDB takes the -d option?

Thanks,
Bob Rossi

[Cgdb-devel] [patch, 3rd try] -d parameter fix and enhancement

[Horst S. <ho...@sc...>]

*sigh* my last try, fixing a SIGSEGV when **argv is NULL when comparing
to "--"... Sorry for the noise.

 cgdb.c  |   13 ++++++++++++-
 usage.c |    3 ++-
 2 files changed, 14 insertions(+), 2 deletions(-)

Index: cgdb/src/cgdb.c
===================================================================
--- cgdb/src/cgdb.c	(revision 830)
+++ cgdb/src/cgdb.c	(working copy)
@@ -719,7 +719,13 @@
 	  exit (0);
 	case 'd':
 	  debugger_path = strdup (optarg);
-	  n += 2;
+	  if (optarg == (*argv)[n + 1]) {
+	    /* optarg is in next argv (-d foo) */
+	    n += 2;
+	  } else {
+	    /* optarg is in this argv (-dfoo) */
+	    n++;
+	  }
 	  break;
 	case 'h':
 	  usage ();
@@ -731,6 +737,11 @@
 
   *argc -= n;
   *argv += n;
+
+  if (**argv && strcmp(**argv, "--") == 0) {
+    (*argc)--;
+    (*argv)++;
+  }
 }
 
 /* init_home_dir: Attempts to create a config directory in the user's home
Index: cgdb/src/usage.c
===================================================================
--- cgdb/src/usage.c	(revision 830)
+++ cgdb/src/usage.c	(working copy)
@@ -13,7 +13,7 @@
 {
 printf( 
 "CGDB Usage:\n"      
-"   cgdb [cgdb options] [gdb options]\n"
+"   cgdb [cgdb options] [--] [gdb options]\n"
 "\n"
 "CGDB Options:\n"
 #ifdef HAVE_GETOPT_H
@@ -27,5 +27,6 @@
 "   -h          Print help (this message) and then exit.\n"
 #endif
 "   -d          Set debugger to use.\n"
+"   --          Separator to avoid ambiguities between gdb and cgdb options.\n"
     );
 }

-- 
PGP-Key 0xD40E0E7A

[Cgdb-devel] -d parameter fix and enhancement

[Horst S. <ho...@sc...>]

Re-sending my previous patch, which now

-  patches SVN HEAD (r830)
-  modifies cgdb/src/usage.c instead of the autogenerated cgdb.1


 cgdb.c  |   13 ++++++++++++-
 usage.c |    3 ++-
 2 files changed, 14 insertions(+), 2 deletions(-)

Index: cgdb/src/cgdb.c
===================================================================
--- cgdb/src/cgdb.c	(revision 830)
+++ cgdb/src/cgdb.c	(working copy)
@@ -719,7 +719,13 @@
 	  exit (0);
 	case 'd':
 	  debugger_path = strdup (optarg);
-	  n += 2;
+	  if (optarg == (*argv)[n + 1]) {
+	    /* optarg is in next argv (-d foo) */
+	    n += 2;
+	  } else {
+	    /* optarg is in this argv (-dfoo) */
+	    n++;
+	  }
 	  break;
 	case 'h':
 	  usage ();
@@ -731,6 +737,11 @@
 
   *argc -= n;
   *argv += n;
+
+  if (strcmp(**argv, "--") == 0) {
+    (*argc)--;
+    (*argv)++;
+  }
 }
 
 /* init_home_dir: Attempts to create a config directory in the user's home
Index: cgdb/src/usage.c
===================================================================
--- cgdb/src/usage.c	(revision 830)
+++ cgdb/src/usage.c	(working copy)
@@ -13,7 +13,7 @@
 {
 printf( 
 "CGDB Usage:\n"      
-"   cgdb [cgdb options] [gdb options]\n"
+"   cgdb [cgdb options] [--] [gdb options]\n"
 "\n"
 "CGDB Options:\n"
 #ifdef HAVE_GETOPT_H
@@ -27,5 +27,6 @@
 "   -h          Print help (this message) and then exit.\n"
 #endif
 "   -d          Set debugger to use.\n"
+"   --          Separator to avoid ambiguities between gdb and cgdb options.\n"
     );
 }

-- 
PGP-Key 0xD40E0E7A

[Cgdb-devel] [patch] -d parameter fix and enhancement

[Horst S. <ho...@sc...>]

Hi,

when using cgdb 0.6.3, I stumbled upon the following problem when
trying to pass additional source paths to gdb by invoking cgdb this way:

$ cgdb -d/tmp dot

This of course does not work, as I learned very soon, due to the fact
that -d is a valid parameter for both cgdb and gdb; this is annoying,
but fixable.

But while trying to figure out what was wrong, I realized that there's a
bug in cgdb regarding the very same parameter:

$ gdb cgdb
GNU gdb 6.5
Copyright (C) 2006 Free Software Foundation, Inc.
[...]
(gdb) run -d/tmp
Starting program: /usr/bin/cgdb -d/tmp
Failed to read a valid object file image from memory.
(no debugging symbols found)
[...]
*** glibc detected *** free(): invalid pointer: 0x08071c80 ***

Program received signal SIGABRT, Aborted.
0xb7eee410 in ?? ()


After some debugging, I figured out the bug sits is in the
parse_long_options() function in cgdb.c: n gets increased by 2 even if
the -d parameter was passed as one argv entry (as in "-dfoo"), although
2 is only correct for separate argv entries (as in "-d foo").

Please consider including my patch (see below) in your cgdb sources; it
addresses the mentioned "-dfoo vs. -d foo" bug, adds a way to cleanly
separate cgdb parameters from gdb parameters, and documents this in the
man page.

After applying it, you can start cgdb this way:

$ cgdb -d/some/specific/gdb -- -d/tmp -d/foo dot

Btw: Thanks for this nice tool :)

Kind regards,
 Horst


 cgdb/src/cgdb.c |   13 ++++++++++++-
 doc/cgdb.1      |    5 ++++-
 2 files changed, 16 insertions(+), 2 deletions(-)

diff -Nurp cgdb-0.6.3-orig/cgdb/src/cgdb.c cgdb-0.6.3/cgdb/src/cgdb.c
--- cgdb-0.6.3-orig/cgdb/src/cgdb.c	2006-06-03 20:09:06.000000000 +0200
+++ cgdb-0.6.3/cgdb/src/cgdb.c	2006-08-02 18:34:35.000000000 +0200
@@ -717,7 +717,13 @@ parse_long_options (int *argc, char ***a
 	  exit (0);
 	case 'd':
 	  debugger_path = strdup (optarg);
-	  n += 2;
+	  if (optarg == (*argv)[n + 1]) {
+	    /* optarg is in next argv (-d foo) */
+	    n += 2;
+	  } else {
+	    /* optarg is in this argv (-dfoo) */
+	    n++;
+	  }
 	  break;
 	case 'h':
 	  usage ();
@@ -729,6 +735,11 @@ parse_long_options (int *argc, char ***a
 
   *argc -= n;
   *argv += n;
+
+  if (strcmp(**argv, "--") == 0) {
+    (*argc)--;
+    (*argv)++;
+  }
 }
 
 /* init_home_dir: Attempts to create a config directory in the user's home
diff -Nurp cgdb-0.6.3-orig/doc/cgdb.1 cgdb-0.6.3/doc/cgdb.1
--- cgdb-0.6.3-orig/doc/cgdb.1	2006-06-03 20:10:47.000000000 +0200
+++ cgdb-0.6.3/doc/cgdb.1	2006-08-02 18:44:50.000000000 +0200
@@ -5,7 +5,7 @@ CGDB \- manual page for CGDB 0.6.3

 .SH DESCRIPTION
 .SS "CGDB Usage:"
 .IP
-cgdb [cgdb options] [gdb options]
+cgdb [cgdb options] [--] [gdb options]
 .SS "CGDB Options:"
 .TP
 \fB\-\-version\fR
@@ -16,6 +16,9 @@ Print help (this message) and then exit.
 .TP
 \fB\-d\fR
 Set debugger to use.
+.TP
+\fB\-\-\fR
+Separator to avoid ambiguities between gdb and cgdb options.
 .PP
 Copyright 2002\-2006 Bob Rossi and Mike Mueller.
 CGDB is free software, covered by the GNU General Public License, and you are


-- 
PGP-Key 0xD40E0E7A

[Cgdb-devel] Earn a University Degree based on your professional experience.

[<cg...@vt...>]

<h1 align="center">A Genuine University Degree in 4-6 weeks!</h1>
<div align="center"><br>
  Have you ever thought that the only thing stopping you from a great job and 
  better pay was a few letters behind you name?<br>
  Well now you can get them!<br>
  <br>
  <b><font size="+3">BA BSc MA MSc MBA PhD</font></b><br>
  <br>
  <font size="+2"><b>Within 4-6 weeks!<br>
  No Study Required!<br>
  100% Verifiable!</b></font><br>
  <br>
  These are real, genuine degrees that include Bachelors, Masters, MBA and Doctorate 
  Degrees. They are fully verifiable and certified transcripts are also available. 
  <br>
  <br>
  <b><font size="5">Just call the number below.<br>
  You’ll thank me later…<br>
  </font></b><br>
  <font color="#FF0033" size="+2"><b>1-815-828-2222</b></font><br>
  24 hours a day, 7 days a week including Sundays and Holidays<br>
</div><BR><BR><BR><BR><BR><BR><BR><BR><BR><BR><BR><BR><BR><BR><BR><BR><BR><BR><BR><BR
><BR><BR><BR><BR><BR><BR><BR><BR><BR><BR><BR><BR><BR><BR><BR>read Harrys mind; the corners of his mouth twitched slightly.

Re: [Cgdb-devel] Bug in cgdb.texinfo

[Andrew L. <lof...@fa...>]

>>Do you mind building CGDB from source and telling me if things work for
>>you now?

Yeah, it works...

Andrew

Re: [Cgdb-devel] Bug in cgdb.texinfo

[Andrew L. <lof...@fa...>]

Hey Bob,

I'm sure that the change works--it's very minor.  I haven't yet built the
latest SVN version because I'd have to download texinfo (including tetex)
and, well, I'd rather not at the moment :)

I would like to maintain the package for Fedora Extras, but since I'm not
yet a Fedora contributor, it might take a little while.  By the way, which
features/bug fixes from readline-5.1 are required for cgdb?  Right now
Fedora includes readline-5.0, with some patches.  I've packaged readline-5.1
for Fedora and built my cgdb package against it, but I'm not sure how
successful I'll be at getting the updated readline package into Fedora--it's
part of Core.  It will eventually be updated, but I'm not sure when.
Perhaps you could put both readline-5.1 and cgdb-0.6.3 packages up on
Sourceforge for download?  At least until I get cgdb accepted into Extras.
This would also help get the package into Extras since it needs to be
available somewhere online where others can review it.


Andrew L.

Re: [Cgdb-devel] objc support

[Bob R. <bob...@co...>]

On Sat, Jun 17, 2006 at 11:48:58AM +0200, Jens Frederich wrote:
> below on this mail is a little objective-c patch. By me it's works very 
> well.

Hi Jens,

Thanks for the patch, I'm going to try to review this with you over the
next few days. In general it looks really good. I think it's time I set
up a small test suite which checks that the tokenizer is still working.

I have a small example for C called ctest.c and an even smaller example
for ada called adatest.adb. Could you provide me with an objctest.m 
example file? That way, at a minimum, we can compare results to what 
we used to have when we make changes.

I noticed the patch was in the reverse order, is there any way you could
switch that around for me, or should I just use the reverse patch
feature?

Clearly the patch to tokenizer.h is correct as well as the patch to
Makefile.am. A quick question about objclexer.l, does objective c have
  - the same c style commands 
  - the same C++ style comments 
  - the same C style string literals
as the clexer.l file? Can you take any of those constructs and put them
in a .c file?

Other than this, this patch looks great! Thanks for the work.
Bob Rossi

Re: [Cgdb-devel] Bug in cgdb.texinfo

[Bob R. <bob...@co...>]

On Sat, Jun 24, 2006 at 10:09:05AM -0400, Andrew Lofthouse wrote:
> Hi all,
> 
> I've just discovered cgdb via cgywin, and now I'm trying to get it
> packaged in Fedora Extras.  I've noticed a minor problem, though.  There
> needs to be some spaces (or tabs) between the name of the texinfo node
> and the title.  Otherwise, info can't find the correct node from the dir
> menu.  Here's a diff:
> 
> --- cgdb-0.6.3/doc/cgdb.info    2006-06-03 14:10:03.000000000 -0400
> +++ cgdb-0.6.3/doc/cgdb.info.new        2006-06-24 08:31:26.000000000
> -0400
> @@ -21,7 +21,7 @@
> 
>  INFO-DIR-SECTION Software development
>  START-INFO-DIR-ENTRY
> -* CGDB: (CGDB)GNU Ncurses front end to GDB.
> +* CGDB: (CGDB)         GNU Ncurses front end to GDB.
>  END-INFO-DIR-ENTRY

I've applied the patch. It looks like this now.

    START-INFO-DIR-ENTRY
    * CGDB: (CGDB).                   GNU Ncurses front end to GDB.
    END-INFO-DIR-ENTRY

Do you mind building CGDB from source and telling me if things work for
you now? Also, are you going to activly maintain CGDB in the Fedora
Extras? If so, we could put this on our web site (cgdb.sf.net).

Bob Rossi

Re: [Cgdb-devel] Bug in cgdb.texinfo

[Bob R. <bob...@co...>]

On Sat, Jun 24, 2006 at 10:09:05AM -0400, Andrew Lofthouse wrote:
> Hi all,
> 
> I've just discovered cgdb via cgywin, and now I'm trying to get it
> packaged in Fedora Extras.  I've noticed a minor problem, though.  There
> needs to be some spaces (or tabs) between the name of the texinfo node
> and the title.  Otherwise, info can't find the correct node from the dir
> menu.  Here's a diff:
> 
> --- cgdb-0.6.3/doc/cgdb.info    2006-06-03 14:10:03.000000000 -0400
> +++ cgdb-0.6.3/doc/cgdb.info.new        2006-06-24 08:31:26.000000000
> -0400
> @@ -21,7 +21,7 @@
> 
>  INFO-DIR-SECTION Software development
>  START-INFO-DIR-ENTRY
> -* CGDB: (CGDB)GNU Ncurses front end to GDB.
> +* CGDB: (CGDB)         GNU Ncurses front end to GDB.
>  END-INFO-DIR-ENTRY

Yes, I see this now, thanks.
I will apply this to the trunk.

Thanks,
Bob Rossi

[Cgdb-devel] Bug in cgdb.texinfo

[Andrew L. <lof...@fa...>]

Hi all,

I've just discovered cgdb via cgywin, and now I'm trying to get it
packaged in Fedora Extras.  I've noticed a minor problem, though.  There
needs to be some spaces (or tabs) between the name of the texinfo node
and the title.  Otherwise, info can't find the correct node from the dir
menu.  Here's a diff:

--- cgdb-0.6.3/doc/cgdb.info    2006-06-03 14:10:03.000000000 -0400
+++ cgdb-0.6.3/doc/cgdb.info.new        2006-06-24 08:31:26.000000000
-0400
@@ -21,7 +21,7 @@

 INFO-DIR-SECTION Software development
 START-INFO-DIR-ENTRY
-* CGDB: (CGDB)GNU Ncurses front end to GDB.
+* CGDB: (CGDB)         GNU Ncurses front end to GDB.
 END-INFO-DIR-ENTRY

Regards,

Andrew L.

[Cgdb-devel] CGDB && SVN

[Bob R. <bob...@co...>]

Hi All,

I've switched CGDB over to using SVN. You can follow the instructions
to download CGDB from here:
  http://sourceforge.net/svn/?group_id=72581

If you want to just check out the trunk of CGDB, you can issue the
command 
  svn co https://svn.sourceforge.net/svnroot/cgdb/cgdb/trunk cgdb

Let me know if this does not work. BTW, in case you didn't realize. The
CVS repository is now considered deprecated. All new patches should go
into the SVN repository, since this is what the releases will be done
off of.

Thanks,
Bob Rossi

Re: [Cgdb-devel] [patch] Build system bug fix (GNU readline & history related)

[Bob R. <bob...@co...>]

On Wed, May 17, 2006 at 12:32:18PM +0200, Lubomir Kundrak wrote:
> Hi!
> 
> In my system, CGDB failed to build, because the build system didn't
> detect the history part of GNU readline library correctly. It was due
> to its dependency on functions from the curses library. To correct this
> the curses library has to be added to LIBS prior to attempt to detect
> the GNU history library. The patch below fixes this.
> 
> Another issue (this patch doesn't correct it) is that ./configure
> completes successfully even after unsuccessful detection of GNU history
> library, which CGDB is dependent on.
> 
> In case of replying, please CC the reply to me, as I don't read this
> mailing list.
> 
> best regards,
> Lubo

Hi Lubo,

I believe I have fixed this problem already in CGDB CVS. Do you feel
like trying it out? 

  http://brasko.net:81/bob/cgdb-0.6.2-cvs.tar.gz

I have to double check what I did is correct. I made the assumption that
if the user has readline installed, they have to have the history
library installed. So I only check for readline. I'm going to email the
readline maintainer and make sure this is correct.

Bob Rossi

[Cgdb-devel] [patch] Build system bug fix (GNU readline & history related)

[Lubomir K. <lku...@sk...>]

Hi!

In my system, CGDB failed to build, because the build system didn't
detect the history part of GNU readline library correctly. It was due
to its dependency on functions from the curses library. To correct this
the curses library has to be added to LIBS prior to attempt to detect
the GNU history library. The patch below fixes this.

Another issue (this patch doesn't correct it) is that ./configure
completes successfully even after unsuccessful detection of GNU history
library, which CGDB is dependent on.

In case of replying, please CC the reply to me, as I don't read this
mailing list.

best regards,
Lubo

--- configure.in.orig   2006-05-17 09:56:37.000000000 +0200
+++ configure.in
@@ -121,6 +121,13 @@ if test "$use_ncurses_library" = "no"; t
        curses_lib_name="curses"
 fi

+dnl Made it this far, add the termcap
+LIBS="$TERMCAP_LIB $LIBS"
+dnl Add the ncurses/curses lib, if it's not the same as the termcap lib
+if test "$TERMCAP_LIB" != "-l$curses_lib_name"; then
+  LIBS="-l$curses_lib_name $LIBS"
+fi
+
 dnl Make sure there is a version of readline that CGDB supports.
 dnl Simply putting 5.1* -> 5.9* just to take into accout future versions.
 RL_LIB_READLINE_VERSION
@@ -136,12 +143,8 @@ esac
 dnl This will DEFINE the readline headers.
 RL_LIB_READLINE_INCLUDES

-dnl Made it this far, add the readline and termcap LIBS
-LIBS="-lreadline $TERMCAP_LIB $LIBS"
-dnl Add the ncurses/curses lib, if it's not the same as the termcap lib
-if test "$TERMCAP_LIB" != "-l$curses_lib_name"; then
-  LIBS="-l$curses_lib_name $LIBS"
-fi
+dnl Made it this far, add the readline
+LIBS="-lreadline $LIBS"

 dnl Checks for header files.
 AC_HEADER_STDC

-- 
  o	Lubomir Kundrak
 *O*	<lku...@sk...>, http://skosi.org/~lkundrak/
 (_)	SKOSI -- Slovak OpenSource Initiative

Re: [Cgdb-devel] site for hosting CGDB

[Mike M. <mi...@su...>]

What about berlios.de?

On 5/16/06, Bob Rossi <bob...@co...> wrote:
> Hi,
>
> I've been thinking about moving away from sourceforge.net. It's always
> down. Has anyone had any experience with http://savannah.gnu.org/?
>
> Thanks,
> Bob Rossi
>
>
> -------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job ea=
sier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronim=
o
> http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=
=3D121642
> _______________________________________________
> Cgdb-devel mailing list
> Cgd...@li...
> https://lists.sourceforge.net/lists/listinfo/cgdb-devel
>

[Cgdb-devel] site for hosting CGDB

[Bob R. <bob...@co...>]

Hi,

I've been thinking about moving away from sourceforge.net. It's always
down. Has anyone had any experience with http://savannah.gnu.org/?

Thanks,
Bob Rossi

Re: [Cgdb-devel] autoconf files

[Robert L. <rob...@se...>]

On Fri, Apr 14, 2006 at 03:16:30PM -0400, Bob Rossi wrote:
> I'm going to remove the generated autoconf files from CVS.
> I will however generate them, and put them into the releases.
>=20
> Is this OK with everyone?

cool for me!

cu  robert

--=20
Robert Lemmen                               http://www.semistable.com=20

[Cgdb-devel] autoconf files

[Bob R. <bob...@co...>]

Hi all,

I'm going to remove the generated autoconf files from CVS.
I will however generate them, and put them into the releases.

Is this OK with everyone?

Thanks,
Bob Rossi