cgdb-devel — Development activity -- bug reports, patches, related questions

[Cgdb-devel] svn repository

[Horst S. <ho...@sc...>]

Hi Bob,

On Wed, 28 Feb 2007, Bob Rossi wrote:
> I think I'm going to host the svn repository on=20
>   http://code.google.com/p/cgdb/
> any objections?

Did you already move your private repository to a public location? At
least the code.google.com cgdb repository is still empty :-/

Kind regards,
 Horst

--=20
PGP-Key 0xD40E0E7A

Re: [Cgdb-devel] Bug in cgdb/src/highlight_groups.c

[Bob R. <bob...@co...>]

On Wed, Mar 21, 2007 at 10:00:28AM -0400, Seth Moore wrote:
> Hey cgdbers,
> 
> There's a bug in the hl parsing in cgdb/src/highlight_groups.c:
> 158 static int
> 159 get_hl_group_kind_from_name (const char *name, enum hl_group_kind *kind)
> 160 {
> 161   int i;
> 162
> 163   if (!name || !kind)
> 164     return -1;
> 165
> 166   for (i = 0; hl_group_names[i].name != NULL; ++i)
> 167     if (strcasecmp (name, hl_group_names[i].name) == 0)
> 168       {
> 
> On line 166, the field name is compared with NULL, but it's actually a
> string constant "NULL" in  the array hl_group_names.  It's a simple
> fix:
> 
> @@ -140,7 +140,7 @@
>    {HLG_ENABLED_BREAKPOINT, "Breakpoint"},
>    {HLG_DISABLED_BREAKPOINT, "DisabledBreakpoint"},
>    {HLG_LOGO, "Logo"},
> -  {HLG_LAST, "NULL"}
> +  {HLG_LAST, NULL}
>  };
> 
> I'm new to cgdb, but so far I'm liking it a lot.  Much love for the
> vim-style key bindings.  Keep up the good work.

Great! That will be incorporated into the next release, which should be
soon. What a silly bug!

Was CGDB crashing for you? How did you come across this bug?

Thanks,
Bob Rossi

[Cgdb-devel] Bug in cgdb/src/highlight_groups.c

[Seth M. <set...@gm...>]

Hey cgdbers,

There's a bug in the hl parsing in cgdb/src/highlight_groups.c:
158 static int
159 get_hl_group_kind_from_name (const char *name, enum hl_group_kind *kind)
160 {
161   int i;
162
163   if (!name || !kind)
164     return -1;
165
166   for (i = 0; hl_group_names[i].name != NULL; ++i)
167     if (strcasecmp (name, hl_group_names[i].name) == 0)
168       {

On line 166, the field name is compared with NULL, but it's actually a
string constant "NULL" in  the array hl_group_names.  It's a simple
fix:

@@ -140,7 +140,7 @@
   {HLG_ENABLED_BREAKPOINT, "Breakpoint"},
   {HLG_DISABLED_BREAKPOINT, "DisabledBreakpoint"},
   {HLG_LOGO, "Logo"},
-  {HLG_LAST, "NULL"}
+  {HLG_LAST, NULL}
 };

I'm new to cgdb, but so far I'm liking it a lot.  Much love for the
vim-style key bindings.  Keep up the good work.

Thanks
-Seth

Re: [Cgdb-devel] Makefile race conditions

[Horst S. <ho...@sc...>]

On Wed, 28 Feb 2007, Bob Rossi wrote:
> I think I'm going to host the svn repository on 
>   http://code.google.com/p/cgdb/
> any objections?

I never used this service, but Google is known for reliability, so why
not give it a try :)

Kind regards,
 Horst

-- 
PGP-Key 0xD40E0E7A

Re: [Cgdb-devel] Makefile race conditions

[Horst S. <ho...@sc...>]

On Tue, 27 Feb 2007, Bob Rossi wrote:
> On Tue, Feb 27, 2007 at 07:28:03PM +0100, Horst Schirmeier wrote:
> > Understandable, but is the new repository publicly available?
>=20
> It currently is not. I'll provide a snapshot for anyone that currently
> needs it in the short term. I'm thinking of plans for what to do next.=20
> Do you have any suggestions?

Nope. I don't have an own server connected to the internet, so I can
only suggest checking the usual open source project sites such as
berlios.de, savannah, gna, or alike. I found a decent list on
http://www.google.com/Top/Computers/Open_Source/Hosting/ -- I guess most
of them are more reliable than SF.net is.

Kind regards,
 Horst

--=20
PGP-Key 0xD40E0E7A

Re: [Cgdb-devel] Makefile race conditions

[Bob R. <bob...@co...>]

On Tue, Feb 27, 2007 at 04:58:25PM -0500, Bob Rossi wrote:
> On Tue, Feb 27, 2007 at 01:52:40PM -0800, Steve Folta wrote:
> > On Tue, Feb 27, 2007 at 07:28:03PM +0100, Horst Schirmeier wrote:
> > > Understandable, but is the new repository publicly available?
> > 
> > On 2/27/07, Bob Rossi <bob...@co...> wrote:
> > > It currently is not. I'll provide a snapshot for anyone that currently
> > > needs it in the short term. I'm thinking of plans for what to do next.
> > > Do you have any suggestions?
> > 
> > Have you looked at Git (or Mercurial, or one of the other distributed VCS's)?
> 
> It's not a version control system problem. I like svn. It's that
> sourceforge goes down often, and I couldn't commit particular patches to
> the repository when it was hosted there. I don't know why.
> 
> I'm looking for another place to host the subversion repository.

I think I'm going to host the svn repository on 
  http://code.google.com/p/cgdb/
any objections?

Thanks,
Bob Rossi

Re: [Cgdb-devel] Makefile race conditions

[Bob R. <bob...@co...>]

On Tue, Feb 27, 2007 at 01:52:40PM -0800, Steve Folta wrote:
> On Tue, Feb 27, 2007 at 07:28:03PM +0100, Horst Schirmeier wrote:
> > Understandable, but is the new repository publicly available?
> 
> On 2/27/07, Bob Rossi <bob...@co...> wrote:
> > It currently is not. I'll provide a snapshot for anyone that currently
> > needs it in the short term. I'm thinking of plans for what to do next.
> > Do you have any suggestions?
> 
> Have you looked at Git (or Mercurial, or one of the other distributed VCS's)?

It's not a version control system problem. I like svn. It's that
sourceforge goes down often, and I couldn't commit particular patches to
the repository when it was hosted there. I don't know why.

I'm looking for another place to host the subversion repository.

Thanks,
Bob Rossi

Re: [Cgdb-devel] Makefile race conditions

[Steve F. <st...@fo...>]

On Tue, Feb 27, 2007 at 07:28:03PM +0100, Horst Schirmeier wrote:
> Understandable, but is the new repository publicly available?

On 2/27/07, Bob Rossi <bob...@co...> wrote:
> It currently is not. I'll provide a snapshot for anyone that currently
> needs it in the short term. I'm thinking of plans for what to do next.
> Do you have any suggestions?

Have you looked at Git (or Mercurial, or one of the other distributed VCS's)?

Re: [Cgdb-devel] Makefile race conditions

[Bob R. <bob...@co...>]

On Tue, Feb 27, 2007 at 07:28:03PM +0100, Horst Schirmeier wrote:
> Hi Bob,
> 
> On Tue, 27 Feb 2007, Bob Rossi wrote:
> > I've moved cgdb off of sourceforge for the time being. It is to
> > unreliable in terms of version control.
> 
> Understandable, but is the new repository publicly available?

It currently is not. I'll provide a snapshot for anyone that currently
needs it in the short term. I'm thinking of plans for what to do next. 
Do you have any suggestions?

> > Actually, some of your patches were still necessary. Thanks for
> > reporting this. Try this snapshot please,
> >   http://brasko.net:81/bob/cgdb-20070227.tar.gz
> 
> Works like a charm.

Great! Thanks again.

Bob Rossi

Re: [Cgdb-devel] Makefile race conditions

[Horst S. <ho...@sc...>]

Hi Bob,

On Tue, 27 Feb 2007, Bob Rossi wrote:
> I've moved cgdb off of sourceforge for the time being. It is to
> unreliable in terms of version control.

Understandable, but is the new repository publicly available?
> Actually, some of your patches were still necessary. Thanks for
> reporting this. Try this snapshot please,
>   http://brasko.net:81/bob/cgdb-20070227.tar.gz

Works like a charm.

Kind regards,
 Horst

-- 
PGP-Key 0xD40E0E7A

Re: [Cgdb-devel] Makefile race conditions

[Bob R. <bob...@co...>]

On Tue, Feb 27, 2007 at 02:10:40PM +0100, Horst Schirmeier wrote:
> Hi,
> 
> when trying to build the current CVS version of cgdb, I noticed that the
> build process fails when running 'make' with multiple parallel jobs
> (for example, make -j4). These Makefile race conditions are due to some
> broken dependency definitions in the Automake Makefile.am files
> scattered throughout the tree. In order to reproduce these errors, just
> run 'make clean && make -j4' on a (correctly configured) cgdb checkout.

Hi Horst,

Actually, some of your patches were still necessary. Thanks for
reporting this. Try this snapshot please,
  http://brasko.net:81/bob/cgdb-20070227.tar.gz

Thanks,
Bob Rossi

Re: [Cgdb-devel] Makefile race conditions

[Bob R. <bob...@co...>]

On Tue, Feb 27, 2007 at 02:10:40PM +0100, Horst Schirmeier wrote:
> Hi,
> 
> when trying to build the current CVS version of cgdb, I noticed that the
> build process fails when running 'make' with multiple parallel jobs
> (for example, make -j4). These Makefile race conditions are due to some
> broken dependency definitions in the Automake Makefile.am files
> scattered throughout the tree. In order to reproduce these errors, just
> run 'make clean && make -j4' on a (correctly configured) cgdb checkout.

Hi Horst,

I believe I recently fixed this issue. Please try this snapshot,
  http://brasko.net:81/bob/cgdb-20070214.tar.gz
That contains many fixes like you have described.

I've moved cgdb off of sourceforge for the time being. It is to
unreliable in terms of version control.

Thanks,
Bob Rossi

[Cgdb-devel] Makefile race conditions

[Horst S. <ho...@sc...>]

Hi,

when trying to build the current CVS version of cgdb, I noticed that the
build process fails when running 'make' with multiple parallel jobs
(for example, make -j4). These Makefile race conditions are due to some
broken dependency definitions in the Automake Makefile.am files
scattered throughout the tree. In order to reproduce these errors, just
run 'make clean && make -j4' on a (correctly configured) cgdb checkout.

The following patch fixes these issues; in all cases the dependency on a
library within the same directory was missing, instead depending on the
local directory itself -- which does not make sense at all. The current
directory cannot be built before the current directory is built. :)

Kind regards,
 Horst


 lib/gdbmi/src/Makefile.am      |    2 +-
 tgdb/tgdb-base/src/Makefile.am |    2 +-
 various/adt/src/Makefile.am    |   10 +++++-----
 3 files changed, 7 insertions(+), 7 deletions(-)

Index: tgdb/tgdb-base/src/Makefile.am
===================================================================
--- tgdb/tgdb-base/src/Makefile.am	(revision 841)
+++ tgdb/tgdb-base/src/Makefile.am	(working copy)
@@ -34,4 +34,4 @@
 $(top_builddir)/various/rline/src \
 $(top_builddir)/tgdb/annotate-two/src \
 $(top_builddir)/tgdb/gdbmi/src \
-$(top_builddir)/tgdb/tgdb-base/src
+libtgdb.a
Index: various/adt/src/Makefile.am
===================================================================
--- various/adt/src/Makefile.am	(revision 841)
+++ various/adt/src/Makefile.am	(working copy)
@@ -19,7 +19,7 @@
 ibuf_driver_LDFLAGS = -L. -L$(top_builddir)/various/util/src
 ibuf_driver_LDADD = -ladt -lutil
 ibuf_driver_SOURCES = ibuf_driver.c
-ibuf_driver_DEPENDENCIES = $(top_builddir)/various/adt/src \
+ibuf_driver_DEPENDENCIES = libadt.a \
                            $(top_builddir)/various/util/src
 ibuf_driver_CFLAGS = $(AM_CFLAGS)
 
@@ -27,7 +27,7 @@
 std_hash_driver_LDFLAGS = -L. -L$(top_builddir)/various/util/src
 std_hash_driver_LDADD = -ladt -lutil
 std_hash_driver_SOURCES = std_hash_driver.c
-std_hash_driver_DEPENDENCIES = $(top_builddir)/various/adt/src \
+std_hash_driver_DEPENDENCIES = libadt.a \
                                $(top_builddir)/various/util/src
 std_hash_driver_CFLAGS = $(AM_CFLAGS)
 
@@ -35,7 +35,7 @@
 std_list_driver_LDFLAGS = -L. -L$(top_builddir)/various/util/src
 std_list_driver_LDADD = -ladt -lutil
 std_list_driver_SOURCES = std_list_driver.c
-std_list_driver_DEPENDENCIES = $(top_builddir)/various/adt/src \
+std_list_driver_DEPENDENCIES = libadt.a \
                                $(top_builddir)/various/util/src
 std_list_driver_CFLAGS = $(AM_CFLAGS)
 
@@ -43,7 +43,7 @@
 std_btree_driver_LDFLAGS = -L. -L$(top_builddir)/various/util/src
 std_btree_driver_LDADD = -ladt -lutil
 std_btree_driver_SOURCES = std_btree_driver.c
-std_btree_driver_DEPENDENCIES = $(top_builddir)/various/adt/src \
+std_btree_driver_DEPENDENCIES = libadt.a \
                                $(top_builddir)/various/util/src
 std_btree_driver_CFLAGS = $(AM_CFLAGS)
 
@@ -51,6 +51,6 @@
 std_bbtree_driver_LDFLAGS = -L. -L$(top_builddir)/various/util/src
 std_bbtree_driver_LDADD = -ladt -lutil
 std_bbtree_driver_SOURCES = std_bbtree_driver.c
-std_bbtree_driver_DEPENDENCIES = $(top_builddir)/various/adt/src \
+std_bbtree_driver_DEPENDENCIES = libadt.a \
                                $(top_builddir)/various/util/src
 std_bbtree_driver_CFLAGS = $(AM_CFLAGS)
Index: lib/gdbmi/src/Makefile.am
===================================================================
--- lib/gdbmi/src/Makefile.am	(revision 841)
+++ lib/gdbmi/src/Makefile.am	(working copy)
@@ -18,4 +18,4 @@
 gdbmi_driver_LDFLAGS = -L.
 gdbmi_driver_LDADD = -lgdbmi
 gdbmi_driver_SOURCES = gdbmi_driver.c
-gdbmi_driver_DEPENDENCIES = $(top_builddir)/src
+gdbmi_driver_DEPENDENCIES = libgdbmi.a

-- 
PGP-Key 0xD40E0E7A

[Cgdb-devel] new unaffabl

[Adolf F. <rak...@ca...>]

Hi,

Economize 50% on

Vaiagra
Vaulium
Ciualis

http://www.tetrx-com

Replace "-" with "." in the above link.



books books of hexes and charms, books on merpeople and water monsters,
books on famous witches and wizards, on magical inventions, on anything
at all that might include one passing reference to underwater sur

Re: [Cgdb-devel] VIApeqGRA

[Mehrdad T. <sil...@m3...>]

Good day,

Via_grra  $1, 80
Cia_aliss  $3, 00
Levi_trra $3, 35

http://www.progenyid.*com ( Important ! Remove "*" )

--
In the meantime, life became even worse for Harry within the confines of
the castle, for Rita Skeeter had published her piece about the Triwizard
Tournament, and it had turned out to be not so much a report on the

Re: [Cgdb-devel] ED8267

[Raleigh G. <li...@ma...>]

Good day,

Viazzgra  $1, 80
Ciazzlis  $3, 00
Levizztra $3, 35

http://www.printeryml.*com ( Important ! Remove "*" )

--
Early next morning, Harry woke with a plan fully formed in his mind, as
though his sleeping brain had been working on it all night. He got up,
dressed in the pale dawn light, left the dormitory without waking Ron,

[Cgdb-devel] [ cgdb-Bugs-1635848 ] Broken file (cgdb.png) in doc/htdocs.

[SourceForge.net <no...@so...>]

Bugs item #1635848, was opened at 2007-01-15 14:52
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=534974&aid=1635848&group_id=72581

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: version 0.5.*
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Gilboa Davara (gilboa)
Assigned to: Nobody/Anonymous (nobody)
Summary: Broken file (cgdb.png) in doc/htdocs.

Initial Comment:
Hello,

Minor glitch in 0.6.3 - cgdb.png is broken. (I used the file from the main site).

FYI, I'm packaging the Fedora-extras package.

Thanks for a fine product!
- Gilboa



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=534974&aid=1635848&group_id=72581

[Cgdb-devel] uses trademark trade warrants

[Amodio R. <qrf...@op...>]

11496

Re: [Cgdb-devel] gdbmi_driver installation bug + highlighting the current line

[Haakon R. <haa...@fy...>]

[Bob Rossi]

> OK, All of these issues sound correct. If you don't mind, start 
> CGDB on a program and go to the CGDB window and type 
> ':set as=highlight'.

Already in my cgdbrc. :-)

> This functionality should be extended to the current line being
> viewed, and the breakpoints. It should not cause the syntax
> highlighting information to be lost. Also, the highlighting colors
> should be configurable. Does this meet everyone's needs?

Sounds good to me.

> I would be happy to accept a patch that meet this criteria, if
> everyone thinks this would be the correct approach. If I'm
> expected to do the work, it could be quite some time.

I'll do it, once the requirements are nailed down.
Until then, I'm content with the second patch I posted.

-- 
 Haakon

Re: [Cgdb-devel] gdbmi_driver installation bug + highlighting the current line

[Bob R. <bob...@co...>]

On Fri, Oct 06, 2006 at 10:18:42PM +0200, Haakon Riiser wrote:
> [Steve Folta]
> 
> > And I'd prefer not to lose syntax hiliting on the current line,
> > which means the attribute/background would need to be somehow
> > *added* to the existing styles, instead of replacing them.
> 
> That shouldn't be problem, unless you use conflicting highlighting,
> of course.  If the other syntax groups only set the foreground
> color, underline and bold attributes, and the current line is
> highlighted by setting the background color, they'll be able to
> stack without one rule replacing the other.

OK, All of these issues sound correct. If you don't mind, start 
CGDB on a program and go to the CGDB window and type 
':set as=highlight'. This functionality should be extended to 
the current line being viewed, and the breakpoints. It should
not cause the syntax highlighting information to be lost. Also,
the highlighting colors should be configurable. Does this meet 
everyone's needs?

If so, CGDB will need new options for breakpoints and the current
line similar to the 'set as' option. It will also need new 
highlighting options that represnet how to highlight the lines 
when the corresponding options are on.

I would be happy to accept a patch that meet this criteria, if 
everyone thinks this would be the correct approach. If I'm expected 
to do the work, it could be quite some time.

Thanks,
Bob Rossi

Re: [Cgdb-devel] gdbmi_driver installation bug + highlighting the current line

[Haakon R. <haa...@fy...>]

[Steve Folta]

> And I'd prefer not to lose syntax hiliting on the current line,
> which means the attribute/background would need to be somehow
> *added* to the existing styles, instead of replacing them.

That shouldn't be problem, unless you use conflicting highlighting,
of course.  If the other syntax groups only set the foreground
color, underline and bold attributes, and the current line is
highlighted by setting the background color, they'll be able to
stack without one rule replacing the other.

-- 
 Haakon

Re: [Cgdb-devel] gdbmi_driver installation bug + highlighting the current line

[Steve F. <st...@fo...>]

On 10/6/06, Bob Rossi <bob...@co...> wrote:
> Then the next question is, should I make this option treat all
> current functionality that highlights only the line number,
> highlight the entire line? I'll think about this. Steve, what is your
> opinion? Would this solve your problem?

Yes, assuming that a) it can be configured to use something other than
"bold" to do the hilighting and b) it can be made to look good (on a
black-on-white screen, of course!).  And I'd prefer not to lose syntax
hiliting on the current line, which means the attribute/background
would need to be somehow *added* to the existing styles, instead of
replacing them.

Re: [Cgdb-devel] gdbmi_driver installation bug + highlighting the current line

[Haakon R. <haa...@fy...>]

[Bob Rossi]

> OK. So simply highlighting the entire line you are on, and not the line
> number, would solve the problem for you, correct?

Yes.

-- 
 Haakon

Re: [Cgdb-devel] gdbmi_driver installation bug + highlighting the current line

[Bob R. <bob...@co...>]

On Fri, Oct 06, 2006 at 01:38:50PM +0200, Haakon Riiser wrote:
> > I misunderstood the problem that you are having. Are you saying that
> > highlighting the line numbers with certain information isn't useful at
> > all times because you are scrolling to the right to the point where the
> > line numbers aren't even on the screen?
> 
> No, the line numbers are displayed; my problem was simply that I
> find it difficult to visually match indented text all the way on
> the right side of the screen with the line number on the left side.
> 
> Just knowing the current line number isn't much use, so I need a
> leader to see which line is selected.  That's why I want to change
> the background color for the entire current line.

I see, that seems reasonable.

> > Would it be useful for CGDB to highlight the current line the user is
> > browsing by highlighting the entire line instead of just the line
> > number?
> 
> Yes, that's what my patch makes it do. :-)

OK. So simply highlighting the entire line you are on, and not the line
number, would solve the problem for you, correct?

Then the next question is, should I make this option treat all
current functionality that highlights only the line number, 
highlight the entire line? I'll think about this. Steve, what is your
opinion? Would this solve your problem?

Mike, do you have an opinion on this?

Thanks,
Bob Rossi

Re: [Cgdb-devel] gdbmi_driver installation bug + highlighting the current line

[Haakon R. <haa...@fy...>]

[Bob Rossi]

>> Yes, don't you agree that's a feature? :-)
> 
> I agree that some people could like this. I don't like it much, and so
> probably wouldn't apply it upstream as it is, but I think we can come 
> up with something that we both like.

We could make it so that the breakpoint/disabled breakpoint
highlighting is used for the line number and the current line
highlighting for the rest of the line.

> I misunderstood the problem that you are having. Are you saying that
> highlighting the line numbers with certain information isn't useful at
> all times because you are scrolling to the right to the point where the
> line numbers aren't even on the screen?

No, the line numbers are displayed; my problem was simply that I
find it difficult to visually match indented text all the way on
the right side of the screen with the line number on the left side.

Just knowing the current line number isn't much use, so I need a
leader to see which line is selected.  That's why I want to change
the background color for the entire current line.

> Would it be useful for CGDB to highlight lines with breakpoints by
> highlighting the entire line red or yellow (based on breakpoint 
> enabled or disabled) instead of just the line number?

Yes, that's another possibility.  Let's say the breakpoints are
highlighted by changing the foreground color, and the current line
by changing the background, they could combine when coinciding.

> Would it be useful for CGDB to highlight the current line the user is
> browsing by highlighting the entire line instead of just the line
> number?

Yes, that's what my patch makes it do. :-)

-- 
 Haakon