[CEDET-devel] add-to-list XEmacs incompatibility in semantic

[Stuart P. <st...@pi...>]

Hi all,

I was trying to fire up the `semantic-show-tag-boundaries-mode' when I
got (wrong-number-of-arguments add-to-list 3). This is the latest CVS
build of cedet 2.x.

This occurs in `semantic-tag-add-hook', line 676 of semantic-tag.el:

(defun semantic-tag-add-hook (tag hook value &optional append)
  "Add onto TAG a HOOK with VALUE."
  (let ((pl (semantic--tag-get-property tag hook)))
    (setq pl (add-to-list 'pl value append))
    (semantic--tag-put-property tag hook pl)))

On XEmacs, add-to-list doesn't have the optional APPEND tag. The emacs
version is:

(defun add-to-list (list-var element &optional append)
"...docs..."
  (if (member element (symbol-value list-var))
      (symbol-value list-var)
    (set list-var
	 (if append
	     (append (symbol-value list-var) (list element))
	   (cons element (symbol-value list-var))))))

XEmacs is:
(defun add-to-list (list-var element)
"...docs..."
  (or (member element (symbol-value list-var))
      (set list-var (cons element (symbol-value list-var)))))

I grepped around and the aforementioned instance is the only one I could
find using the APPEND argument. So, should there be a compatibility
function? Is the append argument necessary here?

Thanks,
Stuart