Re[2]: [CEDET-devel] A patch for semantic-util-modes.el

[Eric M. L. <er...@si...>]

>>> David PONCE <dav...@wa...> seems to think that:
>[...]
>> That's great news.  Now I'll know how to fix the other warnings that
>> occur all over the place.  Is there a way to get a better error I
>> wonder.  That message made no sense to me.
>[...]
>
>Maybe a good solution would be change the tag macro expanders
>definition from something like:
>
>(defun bovine-grammar-INCLUDE-TAG (&rest args)
>  "Expand call to INCLUDE-TAG grammar macro.
>Return the expanded form.
>ARGS are the arguments passed to the macro."
>  `(semantic-tag-new-include ,@args))
>
>to something like:
>
>(defun bovine-grammar-INCLUDE-TAG (name system-flag &rest attributes)
>  "Expand call to INCLUDE-TAG grammar macro.
>Return the expanded form that creates a semantic tag of class include.
>NAME is the name of this include.
>SYSTEM-FLAG represents that we were able to identify this include as belonging
>to the system, as opposed to belonging to the local project.
>ATTRIBUTES is a list of additional attributes belonging to this tag."
>  `(semantic-tag-new-include ,name ,system-flag ,@attributes))
>
>Thus, calling the macro with a wrong number of arguments will fail at
>lisp generation time.
  [ ... ]

That's a good idea.

I've fixed all the avoidable compiler warnings for the semantic lisp
code not in bovine or wisent.  Now I just need time to check it all
in.

Eric

-- 
          Eric Ludlam:                 za...@gn..., er...@si...
   Home: http://www.ludlam.net            Siege: www.siege-engine.com
Emacs: http://cedet.sourceforge.net               GNU: www.gnu.org