Re: [CEDET-devel] One more patch for Java SRecode templating
Brought to you by:
zappo
From: Vladimir K. <vka...@in...> - 2013-02-05 11:54:03
|
> Your patch is a bit puzzling for me. On one side, it seems wrong since > there should be a nice arrangements between contexts and what gets > parsed, except that the for loop is outside said context. > > I can't think of a better way to do it off the top of my head. Seems > like a reasonable idea. It could probably be used for C too. Same for me. That's what I ended up with. I'd spent a few hours trying to come up with a better way to do it, but ugly primitive parsing was all I could do. There's no obvious way to get current or neighboring tags. I could have extended grammar's semantic actions to produce additional tags for for/foreach/etc. Maybe that should be the way? semantic-get-local-variables would become a bit less "hairy". > Local variable parsing has always been a bit of a hack, particularly > since it wanders through your code backward. It would be nice to fix > that someday. That's why I've sent a half-cooked patch. Thought you may come up with a better idea. Yes, sure, the code (built around c-beginning-of-statement-1 function) is useful for all of the C-like languages, although right now I am concentrated on Java only. My general plan is the following: make semantic support all of Java features, make project-wide things in semanticdb work correctly for Java, make things fast using caching and additional indexes, add new features (think refactoring or a callgraph), other things to improve in Cedet. In that particular order. IMHO, Cedet has almost everything one needs to work with Java, but almost every feature I use requires A LOT of additional polishing to be truly usable. So, the main question is: should I finish this patch? I.e. switch to java.wy, add tag generation for for/foreach statements, use the trick in semantic-get-local-variables, add unit ttests for the code -- Yours sincerely, Vladimir Kazanov -- С уважением, Владимир Казанов |