Re: [CEDET-devel] semantic-tag-prototype-p vs semantic-analyze-tag-prototype-p
Brought to you by:
zappo
From: David E. <de...@ra...> - 2011-05-17 21:57:41
|
Eric M. Ludlam writes: > On 05/17/2011 02:46 AM, David Engster wrote: >> We have both functions mentioned in the subject and they seem to be >> identical, so I suggest we get rid of one of them. A quick grep shows >> that semantic-tag-prototype-p is used more, so should we drop the >> semantic-analyze-* one? > > I think that makes sense. The log indicates that > semantic-tag-prototype-p is a copy of the one in the analyzer. Probably > because I wanted code unrelated to the analyzer to not depend on > analyzer functions, but I think the reverse is certainly ok. OK, I've now removed semantic-analyze-tag-prototype-p and replaced the few occurrences with semantic-tag-prototype-p. > Thanks for noticing that. Well, I learned it the hard way (which is overloading semantic-tag-prototype-p and wondering why it didn't work ;-) ). -David |