Re: [CEDET-devel] semanticdb-find-default-throttle should be buffer-local
Brought to you by:
zappo
From: Darren H. <dar...@gm...> - 2011-03-10 11:31:36
|
"Eric M. Ludlam" <er...@si...> writes: > I agree. I'm not sure what the implications are, but it seems like the > right solution. Databases like the Emacs Lisp one should still work, > since it uses defvar mode local, and the per-buffer ones should work, > since they set stuff up per buffer. > > I think we should do it anyway because the doc says to use > setq-mode-local to apply new values, so we should be ok. > > I'm not sure what would happen if someone uses custom to customize the > value, but if someone uses (setq ...) in their .emacs, that setting > would stop working. user (setq ...) before loading CEDET will do, otherwise it will not work as user would expect. So make-buffer-local-variable of a customizable variable is a not good idea to me, since different setting of this variable may affect performance drastically. > The alternative is that every DB like global (including cscope, and any > new one) would need to remember to call make-local-variable, which would > be problematic. > hmm, I think make-local-variable is better suited here provided that it is well documented. I just stepped on semanticdb-find-default-throttle which had a long list of omniscience (maybe hundreds in one of my project), it seems not pretty to me. I am not sure whether it will affect performance during tags search, will it? |