Re: [CEDET-devel] semanticdb-find-default-throttle should be buffer-local

[Eric M. L. <er...@si...>]

On 03/10/2011 01:40 AM, David Engster wrote:
> Eric M. Ludlam writes:
>> This seems like a good idea to me.
>>
>> For other databases (like the Emacs Lisp one) it uses defvar-mode-local
>> which had this effect.  The GNU Global one is different since it is
>> per-buffer, not per mode, so it can't do that, so this seems like the
>> best solution.
>
> So... should we install it? I'm not sure about the implications, but
> at least at the moment I think this is a good idea. :-)

I agree.  I'm not sure what the implications are, but it seems like the 
right solution.  Databases like the Emacs Lisp one should still work, 
since it uses defvar mode local, and the per-buffer ones should work, 
since they set stuff up per buffer.

I think we should do it anyway because the doc says to use 
setq-mode-local to apply new values, so we should be ok.

I'm not sure what would happen if someone uses custom to customize the 
value, but if someone uses (setq ...) in their .emacs, that setting 
would stop working.

The alternative is that every DB like global (including cscope, and any 
new one) would need to remember to call make-local-variable, which would 
be problematic.

This makes me realize there is no unit test for semanticdb-el.  *sigh*. 
  There are a lot of old features in Semantic that aren't caught up in 
testing.  :(

Thanks!
Eric