Re: [cedet-semantic] BUG in semantic--tag-find-parent-by-name

[Eric M. L. <er...@si...>]

Thanks!

  I'll check in something like that soon.

Eric

>>> Raf <ra...@fr...> seems to think that:
>oups my patch is wrong :
>
>here is a more correct one I hope :
>
>--- semantic/semantic-tag.el    19 Oct 2008 11:38:12 -0000    1.59
>+++ semantic/semantic-tag.el    3 Dec 2008 13:52:32 -0000
>@@ -742,7 +742,10 @@
>     (when (not stag)
>       (dolist (S supers)
>     (let* ((sname (semantic-tag-name S))
>-           (parts (nreverse (semantic-analyze-split-name sname))))
>+           (parts (semantic-analyze-split-name sname)))
>+          (if (stringp parts)
>+              (setq parts (list parts))
>+            (setq parts (nreverse parts)))
>       (when (string= name (car parts))
>         (setq stag S))
>       )))
>
>
>Raf a écrit :
>> in semantic--tag-find-parent-by-name :
>>
>> the function semantic-analyze-split-name can return either a string or a 
>> list, nreverse will throw an error in case of a string argument.
>>
>> here is a patch proposal :
>>
>> --- semantic/semantic-tag.el    19 Oct 2008 11:38:12 -0000    1.59
>> +++ semantic/semantic-tag.el    2 Dec 2008 09:12:57 -0000
>> @@ -742,8 +742,10 @@
>>      (when (not stag)
>>        (dolist (S supers)
>>      (let* ((sname (semantic-tag-name S))
>> -           (parts (nreverse (semantic-analyze-split-name sname))))
>> -      (when (string= name (car parts))
>> +           (parts (semantic-analyze-split-name sname))
>> +           (sname (and (listp parts) (car (nreverse parts))))
>> +           (sname (and (stringp parts) parts)))
>> +      (when (string= name sname)
>>             (setq stag S))
>>        )))
>>
>>
>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
  [ ... ]

-- 
          Eric Ludlam:                       er...@si...
   Siege: www.siege-engine.com          Emacs: http://cedet.sourceforge.net