Re: [cecd-devel] [PATCH 1/6] [cecd] answer to <Abort> opcode

[Florian F. <f.f...@gm...>]

Hello Pete,

On 12/30/11 15:10, Florian Fainelli wrote:
> Per specification it is mandatory to answer to an<Abort>  message with
> a<Feature Abort>  reply in case the initiator address is not broadcast.
> Any [Abort Reason] can be used.

First of all, let me wish you a happy new year. This patch is missing 
the opcode parameter in the <Feature Abort> message, will fix that.

> ---
>   cecd/cecd.c |    9 +++++++++
>   1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/cecd/cecd.c b/cecd/cecd.c
> index 67c0a6c..48e62b0 100644
> --- a/cecd/cecd.c
> +++ b/cecd/cecd.c
> @@ -962,6 +962,15 @@ int main(int argc, char** argv)
>   			}
>   			len = 0;
>   			break;
> +		case CEC_OP_ABORT:
> +			// Only answer to abort if initiator address is not broadcast
> +			if ((buffer[0]&  0x0f) == 0x0f)
> +				break;
> +			buffer[1] = CEC_OP_FEATURE_ABORT;
> +			buffer[2] = CEC_ABORT_REFUSED;
> +			len = 3;
> +			break;
> +
>   		default:
>   			// Convert to hash, to match against a conf file command
>   			cec_unprocessed[cec_unprocessed_len++] = htab_hash(buffer+1, len-1, htab_cec, 0);