Re: [Cdrdao-devel] START value for index 0 on toc extraction off by one error ?

[Thomas V. S. <th...@ap...>]

On Fri, 2009-07-03 at 11:05 +0200, Denis Leroy wrote:
> On 07/03/2009 10:03 AM, Thomas Vander Stichele wrote:
> > As a further data point, I did the following:
> >
> > - read-cd cure.toc
> > - write cure.toc
> > - read-toc cure2.toc
> >
> > ie, reading a cd, writing it again, then reading the written CD.
> >
> > As you can clearly see from the attachments, there is an off-by-one
> > error on the frame calculation somewhere.  I'm going to assume it's in
> > the reading part after comparing with EAC.
> >
> > In the bug tracker, I found
> > https://sourceforge.net/tracker/?func=detail&aid=604751&group_id=2171&atid=102171
> >
> > which looks like my bug.
> >
> > I'll attach my findings there.
> >
> > It would be nice to get this fixed, but meanwhile I'll work around it.
> > I hope I get told though when this gets fixed :) Otherwise my workaround
> > will get it wrong when it does.
> 
> Thomas, I'll try to address this bug within next week, but it's tricky 
> as this is really in the parsing core of cdrdao, which unfortunately I 
> am not super familiar with.

What is it parsing at that point ? subchannels ?

I'm not 100% sure I've pinpointed the bug, I'm trying with more discs.
I've found one disc where it actually gets 100% correct pre-gap lengths,
which is annoying as it means that for now I don't even have a correct
workaround.

> 
> What is 'EAC' ?

Exact Audio Copy, a Windows program considered by many to be the
reference.

I'm working on a cd ripper that at least quality-wise is comparable to
EAC.


> Also, have you tried the patch that is in bug 604751 first comment ?

Not yet; it's obvious what the patch does, but I don't understand enough
of the subclass code there for the various drivers and I doubt only the
generic one would need fixing.

And so far I'm not sure I"ve pinpointed the bug yet...

Someone providing some confirmation would be good.

Thomas

-- 
Being hung over is like winning the lottery, except they pay you in
regret!
--
Flumotion - the only way to stream!
http://www.flumotion.net/