From: Eric B. <eri...@ya...> - 2004-04-05 21:26:07
|
Denis Leroy wrote: >I had some trouble applying your HTML-ized patch, but i eventually had >it all worked out. > > Sorry about that. I guess I should have used a text file attachment instead of just cutting and pasting. >The only concern i have is that we're adding a brand new command, but >all it does is print the CDDB query which will appear as something >truly obscure for the uninitiated. How about actually doing the CDDB >query and printing it out in human-readable form, with maybe printing >the query string in verbose mode only, or what about modifying the >existing 'read-cddb' command and make its toc-file argument optional >(cddb result is printed to stdout) ? > > Well, as you may have guessed, I only use this command in the context of a script where I pick up the output and submit it to a CDDB server. I wanted to keep it as simple as possible. The usage message says "prints out CDDB query". How about just changing it to "prints out CDDB query for audio CD and exits". If anyone tries the command, they will see an obscure sequence of numbers, but it is quite harmless. If they don't know what a CDDB query is, it isn't hard to find out. Even a Google search for "discid" or "cddb query" will reveal enough to explain it. The reason I added these commands to cdrdao was to simplify a CD ripping and cataloging application I wrote. Before, I had three programs that had to access the CD-ROM drive for different tasks: discid, cdrdao and eject. By absorbing discid and eject into cdrdao I was able to simplify maintenance and porting. >-denis > >--- Eric Benson <eri...@ya...> wrote: > > >>This patch adds a "discid" command that prints the CDDB query string >>for >>the CD in the drive, and it adds --eject as an option to the "unlock" >> >>command. These are both pretty simple and I've been using them for >>over >>a year myself. It would be great if they get added to cdrdao's CVS >>mainline so other folks can use them, plus it would save me from >>having >>to apply them myself! >> >> > > > |