cdrdao-devel

[Cdrdao-devel] dropping multiple files

[Manuel C. <ll...@ja...>]

Hi all,

The problem with adding multiple files is that the tocEdit object return 
0 when no modify is allowed:

   if (!modifyAllowed())
     return 0;

This return code is also "success" when appending the track. This should 
be changed, but why modify is not allowed? Should we add a 
"addMultipleFiles"? I think no, because the problem is that if you do 
this you still can't add another file while reading the first one. Can 
we break this into pieces, this is, checking that we are modifying the 
piece we are scanning, and if this happens then reread/reorder?

Can Andreas give some explanation on how this works and in what order?

Thanks.

-- 
Manuel Clos
ll...@ja...

* Si no puedes hacerlo bien, hazlo bonito (Bill Gates)
* If you can't do it well, do it nice (Bill Gates)

Re: [Cdrdao-devel] dropping multiple files

[Andreas M. <an...@da...>]

Manuel Clos wrote:
> 
> The problem with adding multiple files is that the tocEdit object return
> 0 when no modify is allowed:
> 
>    if (!modifyAllowed())
>      return 0;
> 
> This return code is also "success" when appending the track. This should
> be changed, but why modify is not allowed? Should we add a
> "addMultipleFiles"? I think no, because the problem is that if you do
> this you still can't add another file while reading the first one. Can
> we break this into pieces, this is, checking that we are modifying the
> piece we are scanning, and if this happens then reread/reorder?
> 
> Can Andreas give some explanation on how this works and in what order?

The TocEdit object is set to read-only mode during scanning because
the scan process accesses the Toc object while it does its job. If
we would modify the Toc object during the scanning process it could
lead to unexpected results including a crash.

I think we should extend the existing appendFile/appendTrack functions
to take a list of file names. The function will then first update the
Toc object and then start the scanning process.

If you want to append a file while the scanning process is active we
might either give an appropriate message an let the user abort the
scanning process or we let the function abort the scanning process
and then restart it after the Toc object we modified. This would be
a bit complicated but it should be possible to implement that.

I'm currently completely out of time because of my job (Infineon is
in trouble as you might have heard) and my nephew is currently visiting
us who takes mostly all of my remaining spare time. I'll be more active
again in two weeks.

Regards,
Andreas
-- 
Andreas Mueller                  Tel: +49 89 67808848
Ramsmeierstr. 1                Email: an...@da...
85579 Neubiberg, Germany