Menu

#781 qsarmolecular regressions

Accepted
closed
nobody
master
1
2014-07-16
2014-07-16
John May
No

Resolves the final two failing tests in qsar-molecular:
1. the ALOGP test was testing the wrong molecule, the mistaken was made when SMILES was inlined into cdk source code (e.g. new Atom(), new Atom()) in 2007. The commit lists the git reference.
2. the WHIMDescriptorTest had a test that 'Assert.fail("not tested")' - this is better done with coverage reports (http://wwwdev.ebi.ac.uk/research/steinbeck/jenkins/job/cdk/lastBuild/jacoco/).

https://github.com/johnmay/cdk/compare/patch/qsarmolecuar-regressions

Discussion

  • Egon Willighagen

    Applied and pushed.

     
  • Egon Willighagen

    • status: open --> closed
    • Group: Needs_Review --> Accepted
     

Log in to post a comment.