The Chemistry Development Kit / Patches / #758 Improved property manipulation

#758 Improved property manipulation

Milestone: Accepted

Status: closed

Owner: nobody

Labels: None

Branch: master

Priority: 1

Updated: 2014-05-02

Created: 2014-04-05

Creator: John May

Private: No

Not really used much but setProperties really 'added' - now there are two methods, one to set and one to add. Existing usages have been updated.

https://github.com/johnmay/cdk/compare/chemobject-props-naming

Discussion

Egon Willighagen - 2014-05-02

status: open --> closed

Group: Needs_Review --> Accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Egon Willighagen - 2014-05-02

I think this makes sense. I guess the "set" referred to the property values (and does not implying others get removed), rather than the set of properties, but having both options sounds good to me.

Applied and pushed.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.