Help save net neutrality! Learn more.
Close

#716 Fancy Highlight Generation

Accepted
closed
nobody
render (1)
master
1
2014-01-18
2014-01-02
John May
No

The CDK renderers can not highlight bonds (only available in CDK-JChemPaint). Even then the highlight is simply changing the color of the bond. This class draws the highlight as a separate layer and merges bond/atom highlights together.

Examples seen here: https://plus.google.com/103703750118158205464/posts

Branch: https://github.com/johnmay/cdk/compare/patch;highlight-generator

Discussion

  • Egon Willighagen

    I wonder how this compares to the code for Bioclipse by Arvid...

    Two comments left on GitHub:

    • setProperty() instead of putProperty() in a code example
    • and a question about "atoms with no idea" ... I have no idea what that is about :)

    But otherwise, the patch looks good; the API is easy to use:

    http://egonw.tumblr.com/post/72002958158/playing-with-a-highlighting-patch-from-john-may

    Though we should probably phase out RendererModel.setSelection*() then?

     
    • John May

      John May - 2014-01-02

      Okay have fixed those documentation errors with another commit.

      Though we should probably phase out RendererModel.setSelection*() then?

      I think that’s still useful for single structure selection cases, this was more for generating depictions of many molecules without having to change the renderer. Also it was mainly to allow multiple parts highlighting which isn’t needed in the selection (i.e. atom mapping).

      J

       
  • Egon Willighagen

    • status: open --> closed
    • Group: Needs_Review --> Accepted
     
  • Egon Willighagen

    I haven't heard any complaint from Arvid and my documentation comments are addressed.

    Applied and pushed.

     

Log in to post a comment.