#570 CMLCoreModule storeData() method calls

Needs_Review
closed
nobody
None
master
1
2012-11-06
2012-11-06
No

The storedata() method in the CMLCoreModule calls storeAtomData() and storeBondData() to configure the CDK molecule with the read in atom/bond data. Both methods used to call newAtomData() and newBondData() at the end of the store methods, resetting all variables. This behavior makes extending/overriding the methods counter intuitive in custom CML conventions.

Moving the newAtom/BondData() methods outside the storeAtom/BondData() methods ensures that the methods only do what the methods names say and enable usage of the methods in custom conventions.

1 Attachments

Discussion

  • Egon Willighagen

    Looks good. I'm happy if this makes your customization easier.

    Applied and pushed to master.

     
  • Egon Willighagen

    • status: open --> closed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks