#512 Patch for @cdk.bug 3524092 and 3524093 in ModelBuilder3D

Needs_Review
closed
cdk-1.4.x (181)
5
2012-10-28
2012-05-07
No

This patch solves the @cdk.bug 3524092 and 3524093. See the commit at

https://github.com/danielszisz/cdk/commit/e4f7e8c42dbbfae18fb82961b30874cfbcec947d

Discussion

  • Daniel Szisz

    Daniel Szisz - 2012-05-07

    You can pull the commit from my github repo branch.

     
  • Rajarshi Guha

    Rajarshi Guha - 2012-05-18

    How do I pull a specific commit? Please make a patch for small patches

     
  • Daniel Szisz

    Daniel Szisz - 2012-05-20

    I attached a patch file for the two bugs, @cdk.bug 3524092 and 3524093. The corresponding JUnit tests are
    described in the corresponding bug report. You can solve the bug problem if you apply the patch.

     
  • Egon Willighagen

    Applied and pushed to master.

    Normally we would request unit testing for bug fixes, but since you are working on that, I'm sure that will come...

    (and sorry for the delay... I've had some hectic weeks, and from Rajarshi's activity stream, I guess he's the same...)

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks