From: Rajarshi G. <rx...@ps...> - 2006-06-17 14:02:22
|
On Sat, 2006-06-17 at 15:46 +0200, Egon Willighagen wrote: > Hi all, > > I have been profiling the PDBReader, I found that the major problem is the > contains() check in addAtom() in AtomContainer, Strand and BioPolymer. Taking > these out, brings down running the PDBReaderTest from 27 sec to 11 sec. > > Do we really need this check? We leave a lot of checking to the user in other > places by policy too... It is a useful utility method. Why not keep it in there and note it as an expensive method? ------------------------------------------------------------------- Rajarshi Guha <rx...@ps...> <http://jijo.cjb.net> GPG Fingerprint: 0CCA 8EE2 2EEB 25E2 AB04 06F7 1BB9 E634 9B87 56EE ------------------------------------------------------------------- "whois awk?", sed Grep. |