Re: [Cdk-devel] Distance and similarity measures

[Rajarshi G. <rx...@ps...>]

On Thu, 2006-02-16 at 09:46 +0100, Kai Hartmann wrote:
> So - please discuss it :)

I would suggest making the individual distance measures static methods
of the current similarity class.

I don't see much point in repeating measures (Tanimoto) or placing
related measures in different classes.

> Christoph Steinbeck schrieb:
> > Kai Hartmann wrote:
> >> Good evening,
> >>
> >> a colleague of mine, Asad, wrote a class with several distance and
> >> similarity measures like Tanimoto etc.
> >>
> >> He asked me to commit it to cdk, but I found a class
> >> similarity.Tanimoto. Should I commit anyway? I don't see a use in having
> >> a class for each metric.
> >>
> >> If I commit, Tanimoto will be in two classes. Is this a problem?
> > 
> > My suggestion: Post the class here and let people review it.
> > 
> > Cheers,
> > 
> > Chris
> > 
> 
> 
-------------------------------------------------------------------
Rajarshi Guha <rx...@ps...> <http://jijo.cjb.net>
GPG Fingerprint: 0CCA 8EE2 2EEB 25E2 AB04 06F7 1BB9 E634 9B87 56EE
-------------------------------------------------------------------
He who is in love with himself has at least this advantage -- he won't
encounter many rivals.
-- Georg Lichtenberg, "Aphorisms"