[Cdk-devel] SSSR commit by zzzgggrrr

[E.L. W. <eg...@sc...>]

On IRC I saw an interesting commit related to an SSSR finding algorithm...
I've got some remarks and a question. To start with the question:

what's the difference between the old (current) SSSR algorithm, and the new 
code added to CVS by zzzgggrrr (=uli?)? Is it faster, or more correct, or?

Ok, here are the remarks...

- The build.xml is not updated in CVS to include the new jar.
- The new source files don't have the a license statement, Copyritht CDK etc
- They also do not have JavaDoc
- It seems that the old code moved to a new class (FiguerasSSSRFinder), which
  should be mentioned in the ChangeLog under "API Change". This is very
   important!
- There should be an entry in the ChangeLog anyway
- The source files should state that they @cdk.builddepend and @cdk.depend on
   the new ja
- The new classes do not state to be in the standard module, but are compiled
   with the compile-standard task... this indicates some dependency on the new
   code... where does that come from?

I do not have time to look at all these things, but I hope they can be solved 
soon...

Egon