Re: [Cdk-devel] Re: Missing import declarations in "Viewer" class

[E.L. W. <eg...@sc...>]

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 28 January 2004 14:48, M.Le_maudit wrote:
> > On Wednesday, January 28, 2004 1:08 PM, Egon wrote :
> > > The patch applies on all "org.openscience.applications" package and
> > > sub-packages and does this :
> > > - add the missing import declarations
> > > - remove the unused import declarations
> >
> > Ok, valuable... though there is no clear policy on this...
>
> Ok, it seems that my ideas were not all good ideas. ;-)
> If you think it is a good idea to remove unused import declarations, tell
> me I'll make a patch "only" for this part.

Yes, that's an excellent idea... but without good tools that is difficult..=
=2E=20
but I think there are tools, so if you used one, please add some=20
documentation to the Developers' Guide which tool you used...

> > > - add empty javadoc comments for all non commented fields and methods
> > > (I'm not sure this was a good idea, tell me.)
> >
> > That's not a good idea... without them, tools can detect that the JavaD=
oc
> > is missing, and make statistics out of it... with empty javadoc comments
> > this will go wrong (I think...)...
>
> Ok, I won't do that.
> When I read your stats about javadoc I asked myself the question: "How do
> they [know] that doc is missing?" Now I have the answer. ;-)

:) I think there is a bit in the devel guide on how these stats on the webp=
age=20
are made...

> > > - reformat code
> >
> > Please do not do that.
> > 1. we don't have a certain preferred source code style...
> >     Propose one with a RFC first...
>
> Oh, ... I didn't realize that code format was so important.
> Right now, I do not see any good reason to force other developpers adopt a
> particular code format.

Agreed. So, there is no need to change the format anyway...

> Who am I to do that? I mean I want to help, not to mess everything. :-)

;)

> > 2. the patch is full of restyling, and it is now impossible to see what
> > the actual code changes are...
> > Ummm... please send a corrected patch... I will commit it then...
>
> It's in the attached file. And it only adds the missing import
> declarations. And it's much simpler.

Ok, thanx.

Egon

=2D --=20
eg...@sc...
PhD on Molecular Representation in Chemometrics
Nijmegen University
http://www.cac.sci.kun.nl/people/egonw/
GPG: 1024D/D6336BA6

=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (SunOS)

iD8DBQFAGLYvd9R8I9Yza6YRAtk7AKCsBTKtlwKR6zLWmn2tZ6tiyGM3xgCglVx8
XDlCgTJb9x+vpO41Wzhovlk=3D
=3DUeEU
=2D----END PGP SIGNATURE-----