From: Oliver H. <oli...@th...> - 2002-08-13 12:16:37
|
I had a look at the factory classes in the tools package and I was wondering if combined into one class. The ElementFactory already extend the IsotopeFactory adding the methods getElement and configure. Because of inheritance an ElementFactory instance can also generate Isotopes by calling getIsotopes and getMajorIsotope. And I don't think that there is any reason why there should be a class that can only create Isotopes and a class that can create Isotopes and Elements. Removing a class is always good and wrapping the factory as a singleton will ensure that the xml file is read only once. Making everything nice and tidy and conserving system resources. I can add the suggestion to the wishlist item on SourceForger. SafeBase, the project I am working on, is up for release of version 1 in October so things are a little hectic around here at the moment. |